Skip to content

fix the pycodestyle-minimal linter #40085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

fix the pycodestyle-minimal linter #40085

merged 1 commit into from
May 18, 2025

Conversation

fchapoton
Copy link
Contributor

as this is not longer checked, this breaks at every release, sigh

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton
Copy link
Contributor Author

@tobiasdiez please review

@tobiasdiez
Copy link
Contributor

I would recommend to use ruff instead of pycodestyle. There might be minor differences (and maybe one or two unsupported rules), but in the grand scheme of things it should be a good replacement.

Maybe the ruff config needs to be updated to catch these issues that you now fixed?

@tobiasdiez tobiasdiez added s: positive review p: CI Fix merged before running CI tests and removed s: needs review labels May 12, 2025
@fchapoton
Copy link
Contributor Author

There is no need for the CI fix label as this is not tested anymore.

@tobiasdiez
Copy link
Contributor

The r-string fixes are needed for the meson build. Otherwise it includes warnings that break some doctests.

@fchapoton
Copy link
Contributor Author

well, now meson CI works but the standard CI fails completely...

This was referenced May 14, 2025
Closed
Closed
@tobiasdiez
Copy link
Contributor

well, now meson CI works but the standard CI fails completely...

Do you mean that this PR introduces new failing CI? It seems to me that with and without this PR labeled as "CI fix" the docker-based tests fail due to an issue with Singular.

@fchapoton
Copy link
Contributor Author

you are right. There seems to be issues with version changes in the flint .so also. Not related.

@vbraun vbraun merged commit 8a1fdf6 into sagemath:develop May 18, 2025
12 of 19 checks passed
@fchapoton fchapoton deleted the fix_pycodestyle_mini branch May 18, 2025 11:43
@user202729 user202729 mentioned this pull request May 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: CI Fix merged before running CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @tobiasdiez @vbraun