Meson: make it compile on recent ubuntu #40071
Merged
+428
−570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: @SIMD_CFLAGS@: linker input file not found: No such file or directory
|
Documentation preview for this PR (built with commit 7b1307f; changes) is ready! 🎉 |
|
for me, works fine. |
Is there a better source for the maxima tarball? The maxima spkg also specifies sourceforge as source.
They are actually verified. |
Thanks. Not sure what's wrong here. The cmd encoding looks a bit strange, but then it does try to load maxima... Is this happening on all buildbots? Could you run the above command manually? I also tried to change the command a bit, so maybe now the encoding works better? |
2f93c8b to
7c599c0
Compare
yes, our mirrors have the maxima tarball |
7c599c0 to
de5e820
Compare
That sadly doesn't work as the meson parts should stay independent of sage-the-distro (which is used to populate the mirrors). For example, there is no guarantee that the spkg version is the same as the one used by meson. I've now improved the maxima discovery to also query the sage-the-distro path. I currently don't have means to try it if its really working (but will test it in about 2 weeks). Nonetheless, this should be ready to go, since only it only conflicts with #39030. So setting it back to positive review once the tests are green unless someone protests. |
|
That sounds a lot like you are reinventing the distro wheel. I don't particularly care. But relying solely on sourceforge download urls is going to be super painful. |
|
one can add a Sage mirror as |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40071: Meson: make it compile on recent ubuntu <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Successfully install sage with meson on recent ubuntu (like 25.04), only with system packages pre-installed. Ubuntu is missing maxima (with ecl), so we have to add maxima as a subproject that is build on-the-fly. Also make the python dep lrcalc an optional dependency, since it fails to build (due to missing lrcalc). The other changes are mostly minor updates to the dependency installing and handling in meson. Fixes sagemath#31347. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40038 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40071 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 27, 2025
sagemathgh-40071: Meson: make it compile on recent ubuntu <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Successfully install sage with meson on recent ubuntu (like 25.04), only with system packages pre-installed. Ubuntu is missing maxima (with ecl), so we have to add maxima as a subproject that is build on-the-fly. Also make the python dep lrcalc an optional dependency, since it fails to build (due to missing lrcalc). The other changes are mostly minor updates to the dependency installing and handling in meson. Fixes sagemath#31347. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40038 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40071 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 28, 2025
sagemathgh-40071: Meson: make it compile on recent ubuntu <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Successfully install sage with meson on recent ubuntu (like 25.04), only with system packages pre-installed. Ubuntu is missing maxima (with ecl), so we have to add maxima as a subproject that is build on-the-fly. Also make the python dep lrcalc an optional dependency, since it fails to build (due to missing lrcalc). The other changes are mostly minor updates to the dependency installing and handling in meson. Fixes sagemath#31347. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40038 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40071 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 29, 2025
sagemathgh-40071: Meson: make it compile on recent ubuntu <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Successfully install sage with meson on recent ubuntu (like 25.04), only with system packages pre-installed. Ubuntu is missing maxima (with ecl), so we have to add maxima as a subproject that is build on-the-fly. Also make the python dep lrcalc an optional dependency, since it fails to build (due to missing lrcalc). The other changes are mostly minor updates to the dependency installing and handling in meson. Fixes sagemath#31347. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40038 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40071 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-39030: Use meson in sage-the-distro <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Replace the old setuptools-based build by the new meson-based one in sage-the-distro. Delete most of the old stuff that is no longer needed now. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40133 - sagemath#39973 - sagemath#40071 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39030 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-39030: Use meson in sage-the-distro <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Replace the old setuptools-based build by the new meson-based one in sage-the-distro. Delete most of the old stuff that is no longer needed now. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#40133 - sagemath#39973 - sagemath#40071 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39030 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully install sage with meson on recent ubuntu (like 25.04), only with system packages pre-installed.
Ubuntu is missing maxima (with ecl), so we have to add maxima as a subproject that is build on-the-fly.
Also make the python dep lrcalc an optional dependency, since it fails to build (due to missing lrcalc).
The other changes are mostly minor updates to the dependency installing and handling in meson.
Fixes #31347.
📝 Checklist
⌛ Dependencies