Skip to content

cleaning the groebner_fan file #40064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

cleaning the groebner_fan file #40064

merged 2 commits into from
May 18, 2025

Conversation

fchapoton
Copy link
Contributor

several kinds of enhancements:

  • avoiding bytes_to_str
  • using cached_method
  • code details

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

Documentation preview for this PR (built with commit c52f921; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

dcoudert
dcoudert approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2025
670c26d 
sagemathgh-40064: cleaning the groebner_fan file
    
several kinds of enhancements:

- avoiding bytes_to_str
- using cached_method
- code details

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
    
URL: sagemath#40064
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 00d10b3 into sagemath:develop May 18, 2025
21 of 22 checks passed
@fchapoton fchapoton deleted the gfan_cleanup branch May 18, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: commutative algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun