Skip to content

Upgrade SymPy to 1.10 and update doctests #33398

@mkoeppe

Description

@mkoeppe

SymPy 1.10 was released on 2022-03-06. It still supports Python 3.7, as needed for Sage 9.6.

https://github.com/sympy/sympy/wiki/release-notes-for-1.10

Some doctests needs updating.

From https://github.com/sympy/sympy/runs/5276327276?check_suite_focus=true

sage -t --random-seed=141799432516026950115879763089480345171 src/sage/calculus/calculus.py
**********************************************************************
File "src/sage/calculus/calculus.py", line 1642, in sage.calculus.calculus.laplace
Failed example:
    a, cond
Expected:
    (-oo, True)
Got:
    (0, True)
**********************************************************************

This appears to be a deliberate change in sympy. We update the doctest.

Some doctests need updating because of changes to expression canonicalization in sympy:

sage -t --random-seed=141799432516026950115879763089480345171 src/sage/manifolds/continuous_map.py
**********************************************************************
File "src/sage/manifolds/continuous_map.py", line 1359, in sage.manifolds.continuous_map.ContinuousMap.coord_functions
Failed example:
    Phi.coord_functions(c_UV, c_xyz)
Expected:
    Coordinate functions (-U**2/4 + V**2/4, -(U + V)/(U - V), V)
     on the Chart (M, (U, V))
Got:
    Coordinate functions (-U**2/4 + V**2/4, (-U - V)/(U - V), V) on the Chart (M, (U, V))

We update these doctests. They will fail now with older versions of sympy. However, we do not adjust the version bounds in build/pkgs/sympy/install-requires.txt.

CC: @egourgoulhon @oscarbenjamin

Component: symbolics

Author: Matthias Koeppe

Branch/Commit: 6b7c3a2

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/33398

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions