-
-
Notifications
You must be signed in to change notification settings - Fork 661
Description
Currently, the linters (pycodestyle, pyflakes, ...) run as plugins of patchbot. This has a few disadvantages: a) the lint results depend on the version of the tools installed by the owner of the patchbot b) it takes quite some time until the results are available and c) you need people to run the patchbot.
This ticket adds pyright, relint and pycodestyle checks as Github actions. They run really fast (about 2min), have reliable results as the version of the linters can be controlled and uses Github server instead of people's machines.
Although only those rules are activated that are also run by the patchbot, the pycodestyle and relint checks currently fail with a lot of errors. See https://github.com/tobiasdiez/sage/actions/runs/352364668. Thus, making these tests pass requires more work by the sage community.
What is left to do is to add the integration of the github action output to trac - #30877
CC: @saraedum @mkoeppe @fchapoton @mjungmath @embray @slel @dimpase
Component: build
Keywords: code style, lint
Author: Tobias Diez
Branch/Commit: 51828da
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30404