spkg-check.in: Do not use sdh_make to do 'make check', to avoid misleading messages #29501
Description
sdh_make, even when used for make check, prints the misleading message "Error building $PKG_NAME"
$ grep sdh_make build/pkgs/*/spkg-check.in
build/pkgs/awali/spkg-check.in:sdh_make check
build/pkgs/barvinok/spkg-check.in:sdh_make check
build/pkgs/cocoalib/spkg-check.in:sdh_make check
build/pkgs/e_antic/spkg-check.in:sdh_make check
build/pkgs/fflas_ffpack/spkg-check.in:sdh_make check
build/pkgs/isl/spkg-check.in:sdh_make check
build/pkgs/openblas/spkg-check.in:sdh_make tests $OPENBLAS_CONFIGURE
build/pkgs/openblas/spkg-check.in: sdh_make tests $OPENBLAS_CONFIGURE
build/pkgs/polylib/spkg-check.in:sdh_make check
build/pkgs/polymake/spkg-check.in:sdh_make test
build/pkgs/symengine/spkg-check.in:sdh_make test
build/pkgs/tides/spkg-check.in:sdh_make check AM_CFLAGS="" AM_FFLAGS=""
In the present ticket, we fix this.
We note that when sdh_make is used for building in spkg-install.in, there is duplication with a message printed by sage-spkg afterwards. For example in https://github.com/mkoeppe/sage/runs/581877049:
[python3-3.7.3.p1] TypeError: can only concatenate str (not "NoneType") to str
[python3-3.7.3.p1] make[2]: *** [Makefile:626: sharedmods] Error 1
[python3-3.7.3.p1] make[2]: Target 'all' not remade because of errors.
[python3-3.7.3.p1] make[2]: Leaving directory '/home/runner/work/sage/sage/.tox/local-conda-forge-ubuntu-minimal/local/var/tmp/sage/build/python3-3.7.3.p1/src'
[python3-3.7.3.p1] ********************************************************************************
[python3-3.7.3.p1] Error building python3-3.7.3.p1
[python3-3.7.3.p1] ********************************************************************************
[python3-3.7.3.p1]
[python3-3.7.3.p1] real 3m37.614s
[python3-3.7.3.p1] user 1m37.298s
[python3-3.7.3.p1] sys 0m11.320s
[python3-3.7.3.p1] ************************************************************************
[python3-3.7.3.p1] Error building package python3-3.7.3.p1
[python3-3.7.3.p1] ************************************************************************
[python3-3.7.3.p1] Full log file: /home/runner/work/sage/sage/logs/pkgs/python3-3.7.3.p1.log
However, as this does not have the potential to mislead, we will take care of this on another ticket.
Depends on #29510
CC: @dimpase @jhpalmieri @embray
Component: build
Author: Matthias Koeppe
Branch/Commit: c53ddc7
Reviewer: Dima Pasechnik, John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/29501