Skip to content

Fix dependencies on png.h, m4ri.h, m4rie.h #28352

@jdemeyer

Description

@jdemeyer

The following dependencies were incorrect:

  • sage.matrix.matrix_mod2_dense does not use png.h
  • sage.modules.vector_mod2_dense does not use png.h
  • sage.matrix.matrix_rational_dense does not use m4ri.h

The following dependencies are in Cython files, so Cython picks them up automatically:

  • sage.matrix.matrix_mod2_dense dependency on m4ri.h
  • sage.modules.vector_mod2_dense dependency on m4ri.h
  • sage.matrix.matrix_gf2e_dense dependency on m4rie.h

The following include and dependency was removed:

  • pb_wrap.h included m4ri/m4ri.h for no apparent reason, everything still works after removing that include (and therefore also the dependency)

CC: @dimpase @embray

Component: build

Author: Jeroen Demeyer

Branch/Commit: ca7bfae

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/28352

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions