Skip to content

Conversation

adil192
Copy link
Member

@adil192 adil192 commented Aug 22, 2022

This gives us a few benefits including

  • Scrolling on desktop (scroll-to-zoom) is no longer interpreted as a draw (no more dots everywhere)
  • Zooming/panning gestures can now differ depending on whether you use a finger or stylus
  • We can now scroll on mobile as expected (desktop scrolling is in the works)

@adil192 adil192 merged commit 4a1a4b2 into main Aug 22, 2022
@adil192 adil192 deleted the new_interactive_viewer branch August 22, 2022 17:19
@veudal veudal mentioned this pull request Jul 11, 2025
2 tasks
adil192 added a commit that referenced this pull request Aug 15, 2025
ArgumentError: RangeError (length): Invalid value: Valid value range is empty: -1
  #0      State.widget (package:flutter/src/widgets/framework.dart)
  #1      _EditorBottomSheetState.build (package:saber/components/toolbar/editor_bottom_sheet.dart:67)
  #2      StatefulElement.build (package:flutter/src/widgets/framework.dart:5823)
  #3      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5715)
  #4      StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5874)
  #5      Element.rebuild (package:flutter/src/widgets/framework.dart:5427)
adil192 added a commit that referenced this pull request Aug 17, 2025
LateError: LateInitializationError: Field '_flavor@1865174229' has already been initialized.
  #0      LateError._throwFieldAlreadyInitialized (dart:_internal-patch/internal_patch.dart:209)
  #1      FlavorConfig._flavor= (package:saber/data/flavor_config.dart)
  #2      FlavorConfig.setup (package:saber/data/flavor_config.dart:25)
  #3      EditorCoreInfo.loadFromFileContents.<fn> (package:saber/data/editor/editor_core_info.dart:398)
  #4      WorkerImpl._anotherIsolate.<fn> (package:worker_manager/src/worker/worker_io.dart:102)
  #5      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:193)
adil192 added a commit that referenced this pull request Aug 18, 2025
ConcurrentModificationError: Concurrent modification during iteration: _Set len:1655.
  #0      _CompactIterator.moveNext (dart:_compact_hash:862)
  #1      SaberSyncInterface.findRemoteChanges (package:saber/data/nextcloud/saber_syncer.dart:72)
  File "<asynchronous suspension>"
  #3      SyncerDownloader.doRefresh (package:abstract_sync/src/syncer_downloader.dart:28)
  File "<asynchronous suspension>"
  #5      Mutex.protect (package:mutex/src/mutex.dart:79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant