Skip to content

Set images as background #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 28, 2023
Merged

Set images as background #272

merged 19 commits into from
Jan 28, 2023

Conversation

adil192
Copy link
Member

@adil192 adil192 commented Jan 25, 2023 •
edited
Loading

image
image

Todo:

  • Allow user to change image fit: See https://api.flutter.dev/flutter/painting/BoxFit.html#values
  • Allow user to remove background image
  • If the user sets an image as background when there's already a background image, turn the previous background image into a regular floating image
  • Preserve background image when canvas preview is short (see screenshot of squashed cat)

@adil192 adil192 linked an issue Jan 25, 2023 that may be closed by this pull request
Set image as background image #271
Closed
@adil192 adil192 marked this pull request as draft January 25, 2023 03:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #272 (11cc78d) into main (791bf54) will decrease coverage by 0.19%.
The diff coverage is 4.59%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   18.65%   18.47%   -0.19%     
==========================================
  Files          77       78       +1     
  Lines        4621     4731     +110     
==========================================
+ Hits          862      874      +12     
- Misses       3759     3857      +98
Impacted Files Coverage Δ
lib/components/canvas/_editor_image.dart 13.33% <0.00%> (-0.35%) ⬇️
lib/components/canvas/canvas.dart 0.00% <0.00%> (ø)
...b/components/canvas/canvas_background_preview.dart 0.00% <0.00%> (ø)
lib/components/canvas/canvas_image.dart 0.00% <0.00%> (ø)
lib/components/canvas/canvas_preview.dart 0.00% <0.00%> (ø)
lib/components/canvas/inner_canvas.dart 0.00% <0.00%> (ø)
lib/components/toolbar/editor_bottom_sheet.dart 0.00% <0.00%> (ø)
lib/data/editor/editor_core_info.dart 0.00% <ø> (ø)
lib/data/editor/page.dart 0.00% <0.00%> (ø)
lib/pages/editor/editor.dart 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adil192 adil192 added the enhancement New feature or request label Jan 26, 2023
@adil192 adil192 marked this pull request as ready for review January 28, 2023 11:48
@adil192 adil192 merged commit d58f3f1 into main Jan 28, 2023
@adil192 adil192 deleted the image-background branch January 28, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set image as background image
2 participants
@adil192 @codecov-commenter