fix: moving selection not updating strokes #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 47.15% 47.15% -0.01%
==========================================
Files 114 114
Lines 9002 9003 +1
==========================================
Hits 4245 4245
- Misses 4757 4758 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Works for me on Galaxy Tab S7FE without and problems |
|
I can confirm that it works. |
|
Worked on Galaxy Tab S6 Lite 2020 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
thank you @QubaB! Update: I found another fix which means we don't need to recalculate paths every time |
adil192
added a commit
that referenced
this pull request
May 12, 2025
This solution means we don't need to wipe the cached paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 40116c5 created problem, that when selection is moved, selected paths are not moved together.
Fixes #1394, #1401, #1414