-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
tmpfiles: Allow C escapes #27554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmpfiles: Allow C escapes #27554
Conversation
In cases like this, it is paramount to include a test case. Please extend either |
Yeah, I agree that treating this is a bugfix sounds fine. People were unlikely to put in escape sequences that didn't actually work. |
c5f8265
to
10d9b52
Compare
@keszybz How does that look for the test? First is a commit where the test passes the old behavior, and then the commit that changes the behavior also changes the test to reflect the new behavior. |
10d9b52
to
4b6621f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! It'd be nice to have this backported to stable. |
@keszybz Any chance of this getting backported? |
Fixes #26955
This might be considered a breaking change, because the example from the bug report (
f "/tmp/x/\x20a\nb" 0644 0 0 - \x20foo\nbar
) will now produce a file whose name has the escaped characters instead of a file namedx20anb
. But this behavior reflects the current documentation that says C style escapes are supported.