-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Description
Commit 292420c introduced .github/labeler.yml to automatically add labels to PRs, which is useful.
When these PRs receive forced pushes updating their commits, the labels are unhelpfully getting removed. I haven't attempted to understand why that happens, but it's creating work for us undoing the removals if we want the labels to persist.
Maybe the cause is the forced push doesn't change anything in the directories mapping to the label getting removed, and the bot doesn't know to leave the labels be when that occurs, instead always synchronizing the set of labels to what the latest changset intersects. I don't know, that's just gross speculation.
@jameerpathan111 do you have any idea why this is happening, and how to fix it?
Example: #18013
Note the github-actions bot removed the journal label after the force-push, 29 days later I restored the label.
If we can't address this I'm in favor of disabling the labeler.