Add namespace to the systemd-journal persist name #3407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
Kokan
reviewed
Aug 27, 2020
d4ee7a8 to
2a768bc
Compare
|
Build SUCCESS |
Kokan
previously approved these changes
Sep 2, 2020
If no namespace provided (or not supported), than the legacy name will be used. (systemd_journal) Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
2a768bc to
483fdf6
Compare
|
Build SUCCESS |
gaborznagy
previously approved these changes
Sep 3, 2020
furiel
previously approved these changes
Sep 4, 2020
Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
|
Build SUCCESS |
gaborznagy
approved these changes
Sep 4, 2020
Kokan
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: This PR is a modification on top of #3358 (it should be merged first), however I was unable to open a pull request on: https://github.com/bjoe2k4/syslog-ng
This PR helps to resolve _CURSOR issues in the persist file in case the namespace option changes.
(According to the systemd documentation the _CURSOR identifies an entry. However we got seeking errors in case the namespace parameters changes, even if syslog-ng should seek to the same log entry again.)
This PR also prepares the code to allow multiple systemd-journal sources at the same time. Before systemd v2.45 it was illogical to add multiple journal sources (they could even conflict with each other) so it is prohibited now. However if two journal sources are configured to read from two different namespaces they can work side by side.
I would like to thank for @bjoe2k4 for all the work to introduce the namespace option to the systemd-journal source.