Skip to content

Conversation

HofiOne
Copy link
Collaborator

@HofiOne HofiOne commented Apr 4, 2025

This is a pretty common misconfiguration that should be handled automatically.

Just use syslog(transport(auto)) to automatically accept both octet counted and non-octet counted connections, this opens a TCP port without TLS, meaning it is an implementation of RFC6587.

Backport of by @bazsi

Depends on #5321

@HofiOne HofiOne force-pushed the implement-rfc6587-auto-detection branch from 9cbf03e to c4c5fe2 Compare April 4, 2025 10:50
@kira-syslogng
Copy link
Contributor

Build FAILURE

@folti
Copy link
Contributor

folti commented Apr 13, 2025

@kira-syslogng retest this please

@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the implement-rfc6587-auto-detection branch from c4c5fe2 to fe5612c Compare April 17, 2025 13:27
@kira-syslogng
Copy link
Contributor

Build FAILURE

bazsi added 13 commits April 22, 2025 13:21
…e is 0

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
…ogTransport instances

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
…lected

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
This is just the change in test code, which adds LogProtoServer ** arguments
to the handshake related functions, in order to allow
log_proto_server_handshake to change the LogProto instance.

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
This can be used to simplify LogProtoAutoServer.

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne force-pushed the implement-rfc6587-auto-detection branch from fe5612c to 3dad57d Compare April 22, 2025 11:21
@syslog-ng syslog-ng deleted a comment from github-actions bot Apr 22, 2025
Copy link
Contributor

This Pull Request introduces config grammar changes

syslog-ng/5c20d41c571702f5bf50671e4b18a306e3790d5e -> HofiOne/implement-rfc6587-auto-detection

--- a/destination
+++ b/destination

 network(
     transport(
+        auto
     )
 )

 syslog(
     transport(
+        auto
     )
 )

--- a/source
+++ b/source

 network(
     transport(
+        auto
     )
 )

 syslog(
     transport(
+        auto
     )
 )

@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne merged commit 3c443b3 into syslog-ng:develop Apr 22, 2025
29 of 30 checks passed
@HofiOne HofiOne deleted the implement-rfc6587-auto-detection branch April 22, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants