Skip to content

Conversation

HofiOne
Copy link
Collaborator

@HofiOne HofiOne commented Feb 28, 2025

syslog-ng-ctl: Formatting the output of the syslog-ng-ctl stats and syslog-ng-ctl query commands is unified.

Both commands got a new --format (-m) argument that can control the output format of the given stat or query. The following formats are supported:

  • kv - the legacy key-value-pairs e.g. center.queued.processed=0 (only for the query command yet)
  • csv - comma separated values e.g. center;;queued;a;processed;0
  • prometheus - the prometheus scraper ready format e.g. syslogng_center_processed{stat_instance="queued"} 0

Signed-off-by: Hofi hofione@gmail.com

@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch 2 times, most recently from c58223d to 248d30b Compare February 28, 2025 20:36
@HofiOne HofiOne marked this pull request as ready for review February 28, 2025 20:57
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 248d30b to 7d2eb75 Compare March 1, 2025 18:43
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 7d2eb75 to fa37a76 Compare March 3, 2025 08:36
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from fa37a76 to 6565fd4 Compare March 4, 2025 10:35
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 6565fd4 to 0498b55 Compare March 10, 2025 16:30
@kira-syslogng
Copy link
Contributor

Build FAILURE

HofiOne added 2 commits March 12, 2025 13:40
…d queries

Signed-off-by: Hofi <hofione@gmail.com>
…er validation, sub-commands and options do not need to be double validated

Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 0498b55 to 581c412 Compare March 12, 2025 12:40
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 581c412 to 6420a1b Compare March 12, 2025 16:16
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 6420a1b to 28b3ed3 Compare March 12, 2025 21:08
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 28b3ed3 to 703081e Compare March 12, 2025 21:15
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 703081e to 61d75da Compare March 12, 2025 21:26
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 61d75da to 46a04b2 Compare March 12, 2025 21:30
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 46a04b2 to fd0418c Compare March 12, 2025 21:50
@kira-syslogng
Copy link
Contributor

Build FAILURE

1 similar comment
@kira-syslogng
Copy link
Contributor

Build FAILURE

…ndlers that refers to further parameter parsing issues

Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 28392a9 to 19b5397 Compare March 13, 2025 10:59
@kira-syslogng
Copy link
Contributor

Build FAILURE

HofiOne added 5 commits March 13, 2025 12:19
…r consistently

Signed-off-by: Hofi <hofione@gmail.com>
…ommand, but keep the legacy sub-command version as well to be backward compatible

Signed-off-by: Hofi <hofione@gmail.com>
…y` command

Using now the automatic GLib Commandline Option Parser validation

Signed-off-by: Hofi <hofione@gmail.com>
…sv output formats

Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from 19b5397 to e455f0f Compare March 13, 2025 11:20
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne
Copy link
Collaborator Author

HofiOne commented Mar 14, 2025

@kira-syslogng test this please;

Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne force-pushed the prometheus-stats-query-support branch from e455f0f to 1875511 Compare March 14, 2025 21:30
@kira-syslogng
Copy link
Contributor

Build FAILURE

@HofiOne
Copy link
Collaborator Author

HofiOne commented Mar 18, 2025

@kira-syslogng test this please;

@kira-syslogng
Copy link
Contributor

Build FAILURE

@therandomstring
Copy link
Contributor

@kira-syslogng retest this please

@HofiOne HofiOne merged commit fbc2537 into syslog-ng:develop Mar 20, 2025
27 of 28 checks passed
@HofiOne HofiOne deleted the prometheus-stats-query-support branch March 20, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants