scl: add missing quotes around possibly empty values in the scl template formats #5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae01718 to
6d378cd
Compare
|
Build FAILURE |
6d378cd to
ee6752b
Compare
|
Build FAILURE |
|
@kira-syslogng test this please; |
f6227ad to
7faaf20
Compare
58a0003 to
841b1e3
Compare
kovgeri01
requested changes
Feb 21, 2025
There was a problem hiding this comment.
We should set the Accept-Encoding: identity in the request when trace is enabled(or just in general) until we have a decompresser, to try to force the server from compressing the response if the request was compressed rfc2616#section-14.3
…formats This one is a requirement after https://github.com/syslog-ng/syslog-ng/pull/5080/files just we forgot to update all the scl files we have. Signed-off-by: Hofi <hofione@gmail.com>
…lines Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
…/compression used in the response for later use the header handler and the debug handler are now registered dynamically in each request/response iteration if needed only Signed-off-by: Hofi <hofione@gmail.com>
841b1e3 to
2db66f1
Compare
2db66f1 to
dd68652
Compare
…pression module now showing only a hint in the log how to turn off compression if more detailed HTTP error-loggin is needed Signed-off-by: Hofi <hofione@gmail.com>
dd68652 to
a99cff0
Compare
kovgeri01
approved these changes
Feb 21, 2025
|
Build FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one
Fixes: #5207
Fixes: #2745
Related: #5235
Signed-off-by: Hofi hofione@gmail.com