gsockaddr: V4-mapped addresses should be formatted as an IPv4 address #4674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: there's a unit test in #4673 which needs to be updated if this goes in first or if this one gets rebased. |
Add the possibility of adding a set of LM_V_XXXX handles that are allocated at startup but not "static" in the sense that they are stored in the NVTable as normal dynamic name-value pairs. This mechanism replaces LOG_MSG_GET_VALUE_HANDLE_STATIC() macro and is easier to read and avoids races. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…ndle Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…Source Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
V4-mapped address space is a compatibility feature of dual-stack TCP/IP stacks, where IPv4 connections can be established to IPv6 capable sockets. When this happens, the client IP address would be a V4-mapped address, as determined by the IN6_IS_ADDR_V4MAPPED() function, which is equivalent to an "::FFFF:<ipv4>" address (see RFC3493) This change would trickle into how we fill $HOST if we didn't find a hostname there, previously these would have the form of "::FFFF:ipv4", with this one they would become "ipv4" just as if we received them using an ipv4 specific source. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
d3aaede to
196eb7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this patch has been extracted from #4673
V4-mapped address space is a compatibility feature of dual-stack TCP/IP stacks, where IPv4 connections can be established to IPv6 capable sockets.
When this happens, the client IP address would be a V4-mapped address, as determined by the IN6_IS_ADDR_V4MAPPED() function, which is equivalent to an "::FFFF:" address (see RFC3493)
This change would trickle into how we fill $HOST if we didn't find a hostname there, previously these would have the form of "::FFFF:ipv4", with this one they would become "ipv4" just as if we received them using an ipv4 specific source.