DirectoryMonitor crashes on config reload if there is a pending job in the queue #5085
Description
syslog-ng
Version of syslog-ng
4.8
Steps to reproduce
- setup a syslog-ng server/client config (e.g. any network based source+destination combo)
- read the client input e.g. with a
wildcard-source(that is using inotify or kqueue based directory monitoring) and forward the read input to the network destination, like
source s_wfiles {
wildcard-file(
base-dir("/path")
filename-pattern("*.log")
recursive(no)
monitor-method("auto")
monitor-freq(0.001)
follow-freq(1)
);
};
destination d_network {
network(
0.0.0.0 port(19999)
keep-alive(yes)
);
};
log {
source(s_wfiles);
destination(d_network);
flags(flow-control);
};
- trigger some log message on the client side, e.g.
echo "<3> Sep 2 14:12:58 hostname logger[44739] 5" >> /path/input.log
echo "<3> Sep 2 14:12:58 hostname logger[44739] 6" >> /path/input.log
- stop the server side
- trigger again some log message on the client side, e.g.
echo "<3> Sep 2 14:12:58 hostname logger[44739] 7" >> /path/input.log
echo "<3> Sep 2 14:12:58 hostname logger[44739] 8" >> /path/input.log
- start the server side
- quickly force reload the client side config via
syslog-ng-ctl reload
Result
The client will crash in the directory-monitor cleanup
- with kqueue based directory monitor
[2024-09-03T11:21:35.146132] Closing log transport fd; thread_id='6173618176', fd='18'
[2024-09-03T11:21:35.146132] Stopping directory monitor; thread_id='6173618176', dir='/Users/hofi/Develop/Balabit/syslog-ng/build/install/var'
iv_fd_kqueue_upload_all: got error 2[No such file or directory]
- with inotify based directory monitor
[2024-09-03T14:17:13.768429] Stopping directory monitor; thread_id='140737280923200', dir='/home/hofi/Develop/Balabit/syslog-ng/build/install/var'
[2024-09-03T14:17:13.768429] Free directory monitor; thread_id='140737280923200', dir='/home/hofi/Develop/Balabit/syslog-ng/build/install/var'
iv_fd_epoll_flush_one: got error 2[No such file or directory]