lib/model: Ensure index handler stops on closed connection (fixes #9021) #9035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a slightly different take on this. The way the index handler registry takes the parent Supervisor as a parameter and manipulates that is super funky, I think it should rather be a Supervisor and act accordingly, being stopped/removed by the model when the connection closes. I will file a comparison PR for discussion. |
|
I think I get what you are proposing - makes sense. I think it should expose a (suture) service though, not a supervisor, as it shouldn't be used as a supervisor (except internally). |
|
Right, yes. |
|
Did you already do/implement it or do you want me to update this PR? |
…cthing#9021) The current life-time handling of an index handler is both convoluted and there's no check that it is stopped when the model cleans up connection resources (including the index handler).
9c5753f to
5467d8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current life-time handling of an index handler is both convoluted and there's no check that it is stopped when the model cleans up connection resources (including the index handler).