Skip to content

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Nov 18, 2020

Working on configurable folder/device defaults, I noticed we do not ensure that the local device is always added to folders. We only check that when creating a new config, which is kind of useless. Adding that check requires the wrapper to know about it's own - which is why all the files not in lib/config changed. And working on Configuration.prepare made my head spin, so I decided to split that up into smaller functions and methods on the sub-types. And while at it, I changed util.SetDefaults to recurse into structs, such that we only need to call it once at the top-level (the current way is repetitive and prone to error by forgetting a member).

@calmh calmh merged commit 24af89c into syncthing:main Nov 20, 2020
@imsodin imsodin deleted the all/configRefactor branch November 20, 2020 13:22
@calmh calmh added this to the v1.12.1 milestone Nov 24, 2020
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 21, 2021
@syncthing syncthing locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants