Skip to content

Different lengths used for short device IDs in UI #9313

@KeyWeeUsr

Description

@KeyWeeUsr

Does your log mention database corruption?

No

Include required information

Please be sure to include at least:

  • which version of Syncthing and what operating system you are using
    • 1.27.1, but it's even in main
  • what happened
    • IDs are of different length from API and in client in specific sections
  • what you expected to happen instead
    • same-length IDs

ShortIDStringLength = 7
says 7 and therefore from, let's say /rest/system/connections I get first 7 characters as if split on -
return deviceID.substr(0, 6);
and
return deviceID.substr(0, 6);
however
return id.substr(0, 7) === shortID;
has the matching one and
<td class="text-right">{{ deviceName(devices[deviceCfg.introducedBy]) || deviceCfg.introducedBy.substring(0, 5) }}</td>
has even less than both - 5

Shouldn't it be the same everywhere? Would you welcome a patch or is this something you are aware of and it's kept because of some backward compatibility reason?

Metadata

Metadata

Assignees

No one assigned

    Labels

    frozen-due-to-ageIssues closed and untouched for a long time, together with being locked for discussionuiIssues related to the graphical user interface

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions