Skip to content

Dialogs won't close on Escape key #9489

@bugith

Description

@bugith

What happened?

Some dialogs don’t close on the same action. Namely all dialogs close always OK on click-outside, but never close none of them on Esc key once another tab is selected, unless we click anywhere in it before (that is, an other way to say the same : Escape key works everywhere but just after we select another tab in dialogs). It is like the dialog looses focus on opening new tab. Although this focus loose seems to affect the Esc key only because then hitting Tab rises the focus to the next object (input field, link image…) in the dialog and then Esc works again. Guessed? I’m a keyboard fan, not a friend of rodents, so I’d like we get an homogeneous way everywhere with… Esc.

I seems dialogs are created with a default closeOnEsc attribute, but the tabs are not.

Syncthing version

v1.27.5-rc.2

Platform & operating system

Linux

Browser version

Firefox 124

Relevant log output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew features or improvements of some kind, as opposed to a problem (bug)uiIssues related to the graphical user interface

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions