Conversion to Algebraic Normal Form `to_anf` will now give correct results for a given logical expression. #26183

abhiphile · 2024-02-06T07:21:53Z

Algebraic Normal form (ANF) will be calculated correctly for given expression .

References to other Issues or PRs

Solves Issue #25218

Brief description of what is fixed or changed

Other comments

Release Notes

logic
- Fixed a bug which shows wrong result in computing anf.

sympy-bot · 2024-02-06T07:22:00Z

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

logic
- Fixed a bug which shows wrong result in computing anf. (#26183 by @abhiphile)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Algebraic Normal form (ANF) will be calculated correctly for given expression .

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Solves Issue https://github.com/sympy/sympy/issues/25218


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* logic
  * Fixed a bug which shows wrong result in computing anf.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

github-actions · 2024-02-06T08:10:11Z

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

| Change   | Before [a00718ba]    | After [8824e3ad]    |   Ratio | Benchmark (Parameter)                                                |
|----------|----------------------|---------------------|---------|----------------------------------------------------------------------|
| -        | 69.0±1ms             | 44.5±0.2ms          |    0.64 | integrate.TimeIntegrationRisch02.time_doit(10)                       |
| -        | 68.7±1ms             | 44.3±0.8ms          |    0.65 | integrate.TimeIntegrationRisch02.time_doit_risch(10)                 |
| +        | 18.5±0.2μs           | 29.4±0.8μs          |    1.59 | integrate.TimeIntegrationRisch03.time_doit(1)                        |
| -        | 5.37±0.05ms          | 2.89±0.01ms         |    0.54 | logic.LogicSuite.time_load_file                                      |
| -        | 73.0±0.5ms           | 28.9±0.3ms          |    0.39 | polys.TimeGCD_GaussInt.time_op(1, 'dense')                           |
| -        | 25.7±0.08ms          | 17.0±0.1ms          |    0.66 | polys.TimeGCD_GaussInt.time_op(1, 'expr')                            |
| -        | 73.8±0.5ms           | 28.7±0.1ms          |    0.39 | polys.TimeGCD_GaussInt.time_op(1, 'sparse')                          |
| -        | 255±1ms              | 126±0.4ms           |    0.49 | polys.TimeGCD_GaussInt.time_op(2, 'dense')                           |
| -        | 254±1ms              | 125±0.3ms           |    0.49 | polys.TimeGCD_GaussInt.time_op(2, 'sparse')                          |
| -        | 650±5ms              | 371±1ms             |    0.57 | polys.TimeGCD_GaussInt.time_op(3, 'dense')                           |
| -        | 652±3ms              | 370±1ms             |    0.57 | polys.TimeGCD_GaussInt.time_op(3, 'sparse')                          |
| -        | 496±4μs              | 287±2μs             |    0.58 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense')            |
| -        | 1.78±0.01ms          | 1.07±0.01ms         |    0.6  | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense')            |
| -        | 5.86±0.04ms          | 3.10±0.02ms         |    0.53 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense')            |
| -        | 453±3μs              | 234±2μs             |    0.52 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense')               |
| -        | 1.48±0ms             | 686±5μs             |    0.46 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense')               |
| -        | 4.96±0.03ms          | 1.67±0.01ms         |    0.34 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense')               |
| -        | 373±4μs              | 207±1μs             |    0.55 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense')                |
| -        | 2.40±0.02ms          | 1.24±0.01ms         |    0.52 | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense')                |
| -        | 10.3±0.1ms           | 4.38±0.02ms         |    0.43 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense')                |
| -        | 357±2μs              | 169±1μs             |    0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense')            |
| -        | 2.46±0.01ms          | 882±4μs             |    0.36 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense')            |
| -        | 9.45±0.05ms          | 2.71±0.02ms         |    0.29 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense')            |
| -        | 1.03±0.01ms          | 428±2μs             |    0.41 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense')           |
| -        | 1.74±0.01ms          | 503±2μs             |    0.29 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')          |
| -        | 6.00±0.05ms          | 1.81±0.02ms         |    0.3  | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense')           |
| -        | 8.51±0.09ms          | 1.50±0ms            |    0.18 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')          |
| -        | 290±0.8μs            | 64.3±0.6μs          |    0.22 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')             |
| -        | 3.51±0.02ms          | 399±4μs             |    0.11 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense')              |
| -        | 4.02±0.02ms          | 279±1μs             |    0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')             |
| -        | 7.15±0.03ms          | 1.30±0.01ms         |    0.18 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense')              |
| -        | 8.72±0.02ms          | 839±6μs             |    0.1  | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')             |
| -        | 5.02±0.02ms          | 2.98±0.01ms         |    0.59 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| -        | 12.0±0.08ms          | 6.59±0.03ms         |    0.55 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense')  |
| -        | 22.6±0.2ms           | 9.04±0.01ms         |    0.4  | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| -        | 5.27±0.05ms          | 873±2μs             |    0.17 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')    |
| -        | 12.6±0.05ms          | 7.07±0.03ms         |    0.56 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')    |
| -        | 104±0.3ms            | 26.2±0.1ms          |    0.25 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense')     |
| -        | 169±0.9ms            | 54.1±0.09ms         |    0.32 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')    |
| -        | 177±2μs              | 113±0.9μs           |    0.64 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense')      |
| -        | 364±2μs              | 215±1μs             |    0.59 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse')     |
| -        | 4.37±0.02ms          | 853±4μs             |    0.19 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense')      |
| -        | 5.31±0.05ms          | 384±1μs             |    0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')     |
| -        | 20.2±0.2ms           | 2.83±0.03ms         |    0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense')      |
| -        | 23.0±0.2ms           | 627±6μs             |    0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')     |
| -        | 477±3μs              | 138±0.8μs           |    0.29 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| -        | 4.71±0.03ms          | 619±10μs            |    0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense')  |
| -        | 5.28±0.02ms          | 139±1μs             |    0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| -        | 13.3±0.1ms           | 1.30±0ms            |    0.1  | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense')  |
| -        | 14.0±0.2ms           | 144±1μs             |    0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| -        | 135±0.4μs            | 74.9±1μs            |    0.56 | solve.TimeMatrixOperations.time_rref(3, 0)                           |
| -        | 250±0.9μs            | 86.3±0.3μs          |    0.34 | solve.TimeMatrixOperations.time_rref(4, 0)                           |
| -        | 24.4±0.2ms           | 10.3±0.05ms         |    0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys                       |
| -        | 28.3±0.2ms           | 15.4±0.04ms         |    0.54 | solve.TimeSparseSystem.time_linsolve_Aaug(20)                        |
| -        | 54.7±0.4ms           | 24.9±0.06ms         |    0.45 | solve.TimeSparseSystem.time_linsolve_Aaug(30)                        |
| -        | 28.3±0.2ms           | 15.3±0.09ms         |    0.54 | solve.TimeSparseSystem.time_linsolve_Ab(20)                          |
| -        | 54.2±0.09ms          | 24.5±0.08ms         |    0.45 | solve.TimeSparseSystem.time_linsolve_Ab(30)                          |

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

sympy/logic/boolalg.py

sympy/logic/tests/test_boolalg.py

…lts for a given logical expression.

haru-44 · 2024-02-06T14:04:26Z

looks good. If there are no other suggestions, I will merge them tomorrow.

abhiphile · 2024-02-06T14:33:20Z

looks good. If there are no other suggestions, I will merge them tomorrow.

Thank you for your time .

oscarbenjamin · 2024-02-06T17:00:03Z

Looks good. Thanks

Solves issue sympy#25218

da50259

abhiphile changed the title ~~to_anf will now give correct results Solves Issue #25218~~ Conversion to Algebraic Normal Form to_anf will now give correct results . Feb 6, 2024

abhiphile changed the title ~~Conversion to Algebraic Normal Form to_anf will now give correct results .~~ Conversion to Algebraic Normal Form to_anf will now give correct results . Feb 6, 2024

abhiphile changed the title ~~Conversion to Algebraic Normal Form to_anf will now give correct results .~~ Conversion to Algebraic Normal Form to_anf will now give correct results for a given logical expression. Feb 6, 2024

haru-44 reviewed Feb 6, 2024

View reviewed changes

sympy/logic/boolalg.py Outdated Show resolved Hide resolved

sympy/logic/tests/test_boolalg.py Show resolved Hide resolved

haru-44 linked an issue Feb 6, 2024 that may be closed by this pull request

Incorrect result returned by to_anf #25218

Closed

haru-44 added the logic label Feb 6, 2024

Conversion to Algebraic Normal Form to_anf will now give correct resu…

5e6cc04

…lts for a given logical expression.

oscarbenjamin merged commit bbc5492 into sympy:master Feb 6, 2024

abhiphile deleted the issue-25218 branch March 16, 2024 16:21

oscarbenjamin mentioned this pull request Aug 22, 2024

Nested to_anf Calls Produce Incorrect Results #26985

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Conversion to Algebraic Normal Form `to_anf` will now give correct results for a given logical expression. #26183

Conversion to Algebraic Normal Form `to_anf` will now give correct results for a given logical expression. #26183

Uh oh!

abhiphile commented Feb 6, 2024 •

edited

Loading

Uh oh!

sympy-bot commented Feb 6, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 6, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

haru-44 commented Feb 6, 2024

Uh oh!

abhiphile commented Feb 6, 2024

Uh oh!

oscarbenjamin commented Feb 6, 2024

Uh oh!

Uh oh!

Uh oh!

Conversion to Algebraic Normal Form to_anf will now give correct results for a given logical expression. #26183

Conversion to Algebraic Normal Form to_anf will now give correct results for a given logical expression. #26183

Uh oh!

Conversation

abhiphile commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

Uh oh!

sympy-bot commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haru-44 commented Feb 6, 2024

Uh oh!

abhiphile commented Feb 6, 2024

Uh oh!

oscarbenjamin commented Feb 6, 2024

Uh oh!

Uh oh!

Conversion to Algebraic Normal Form `to_anf` will now give correct results for a given logical expression. #26183

Conversion to Algebraic Normal Form `to_anf` will now give correct results for a given logical expression. #26183

abhiphile commented Feb 6, 2024 •

edited

Loading

sympy-bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading