Changes for _eval_nseries in exp class for wrong outputs #25943

arnabnandikgp · 2023-11-30T17:56:31Z

References to other Issues or PRs

Brief description of what is fixed or changed

Added conditions to handle the case of imaginary exponents along with their test cases

Other comments

Changed code to accommodate cases for when exponential class is called for exponential as well as non exponential bases with imaginary powers and categorised tests as follows:
Type 1: exp(f(x))
Type 2: c**f(x)
Type 3: f(y)**g(x)

Release Notes

functions
- Added conditions for correct handling of imaginary exponents for different bases in _eval_nseries method of Exponential class

sympy-bot · 2023-11-30T17:56:39Z

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

functions
- Added conditions for correct handling of imaginary exponents for different bases in _eval_nseries method of Exponential class (#25943 by @arnabnandikgp)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #24266 

#### Brief description of what is fixed or changed
Added conditions to handle the case of imaginary exponents along with their test cases 

#### Other comments
Changed code to accommodate cases for when exponential class is called for exponential as well as non exponential bases with imaginary powers and categorised tests as follows:
Type 1: exp(f(x)) 
Type 2: c**f(x)
Type 3: f(y)**g(x)

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
  * Added conditions for correct handling of imaginary exponents for different bases in _eval_nseries method of Exponential class 


<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

sympy/functions/elementary/exponential.py

sympy/series/tests/test_series.py

github-actions · 2023-11-30T18:46:40Z

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

| Change   | Before [a00718ba]    | After [f6bf7438]    |   Ratio | Benchmark (Parameter)                                                |
|----------|----------------------|---------------------|---------|----------------------------------------------------------------------|
| -        | 69.5±1ms             | 44.5±0.4ms          |    0.64 | integrate.TimeIntegrationRisch02.time_doit(10)                       |
| -        | 69.0±0.9ms           | 43.0±0.4ms          |    0.62 | integrate.TimeIntegrationRisch02.time_doit_risch(10)                 |
| +        | 18.9±0.5μs           | 29.9±0.6μs          |    1.58 | integrate.TimeIntegrationRisch03.time_doit(1)                        |
| -        | 5.55±0.08ms          | 2.85±0.01ms         |    0.51 | logic.LogicSuite.time_load_file                                      |
| -        | 73.0±0.7ms           | 28.7±0.1ms          |    0.39 | polys.TimeGCD_GaussInt.time_op(1, 'dense')                           |
| -        | 26.2±0.1ms           | 17.0±0.06ms         |    0.65 | polys.TimeGCD_GaussInt.time_op(1, 'expr')                            |
| -        | 73.8±0.3ms           | 29.0±0.03ms         |    0.39 | polys.TimeGCD_GaussInt.time_op(1, 'sparse')                          |
| -        | 254±0.8ms            | 125±0.5ms           |    0.49 | polys.TimeGCD_GaussInt.time_op(2, 'dense')                           |
| -        | 257±2ms              | 125±0.5ms           |    0.49 | polys.TimeGCD_GaussInt.time_op(2, 'sparse')                          |
| -        | 659±2ms              | 373±2ms             |    0.57 | polys.TimeGCD_GaussInt.time_op(3, 'dense')                           |
| -        | 661±3ms              | 372±1ms             |    0.56 | polys.TimeGCD_GaussInt.time_op(3, 'sparse')                          |
| -        | 495±2μs              | 286±0.8μs           |    0.58 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense')            |
| -        | 1.79±0.02ms          | 1.05±0.01ms         |    0.59 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense')            |
| -        | 5.78±0.05ms          | 3.05±0.01ms         |    0.53 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense')            |
| -        | 443±2μs              | 227±1μs             |    0.51 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense')               |
| -        | 1.48±0.01ms          | 660±6μs             |    0.45 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense')               |
| -        | 4.79±0.03ms          | 1.64±0.01ms         |    0.34 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense')               |
| -        | 376±4μs              | 204±0.9μs           |    0.54 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense')                |
| -        | 2.46±0ms             | 1.24±0ms            |    0.5  | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense')                |
| -        | 10.3±0.03ms          | 4.29±0.02ms         |    0.42 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense')                |
| -        | 361±2μs              | 171±1μs             |    0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense')            |
| -        | 2.51±0.04ms          | 914±5μs             |    0.36 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense')            |
| -        | 9.57±0.1ms           | 2.62±0.01ms         |    0.27 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense')            |
| -        | 1.03±0.02ms          | 427±5μs             |    0.41 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense')           |
| -        | 1.74±0.01ms          | 501±3μs             |    0.29 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')          |
| -        | 5.89±0.1ms           | 1.81±0.01ms         |    0.31 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense')           |
| -        | 8.54±0.02ms          | 1.48±0.01ms         |    0.17 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')          |
| -        | 286±1μs              | 64.5±0.3μs          |    0.23 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')             |
| -        | 3.43±0.02ms          | 395±4μs             |    0.12 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense')              |
| -        | 3.97±0.04ms          | 276±0.9μs           |    0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')             |
| -        | 7.05±0.03ms          | 1.28±0.01ms         |    0.18 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense')              |
| -        | 8.57±0.04ms          | 834±4μs             |    0.1  | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')             |
| -        | 5.03±0.03ms          | 2.96±0.01ms         |    0.59 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| -        | 12.0±0.07ms          | 6.51±0.03ms         |    0.54 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense')  |
| -        | 22.3±0.06ms          | 9.03±0.04ms         |    0.4  | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| -        | 5.22±0.03ms          | 868±3μs             |    0.17 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')    |
| -        | 12.8±0.08ms          | 6.99±0.02ms         |    0.55 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')    |
| -        | 102±3ms              | 25.7±0.1ms          |    0.25 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense')     |
| -        | 166±0.9ms            | 53.7±0.5ms          |    0.32 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')    |
| -        | 172±0.5μs            | 111±0.3μs           |    0.64 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense')      |
| -        | 360±4μs              | 216±4μs             |    0.6  | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse')     |
| -        | 4.28±0.04ms          | 834±4μs             |    0.19 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense')      |
| -        | 5.31±0.07ms          | 375±0.5μs           |    0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')     |
| -        | 19.8±0.2ms           | 2.83±0.04ms         |    0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense')      |
| -        | 22.9±0.08ms          | 619±2μs             |    0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')     |
| -        | 482±4μs              | 135±0.7μs           |    0.28 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| -        | 4.69±0.05ms          | 610±2μs             |    0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense')  |
| -        | 5.26±0.05ms          | 137±0.9μs           |    0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| -        | 13.3±0.1ms           | 1.30±0ms            |    0.1  | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense')  |
| -        | 14.0±0.04ms          | 142±1μs             |    0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| -        | 132±1μs              | 76.7±0.3μs          |    0.58 | solve.TimeMatrixOperations.time_rref(3, 0)                           |
| -        | 251±1μs              | 88.8±0.7μs          |    0.35 | solve.TimeMatrixOperations.time_rref(4, 0)                           |
| -        | 24.2±0.03ms          | 10.2±0.03ms         |    0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys                       |

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

smichr · 2023-12-01T03:01:46Z

In absence of any other feedback, this looks like it is restoring the desired behavior and can be committed.

anutosh491 · 2023-12-01T04:53:06Z

Please refrain from merging this PR. I introduced these changes around 1.5 years back and also worked on them during my GSoC project. I would like to thoroughly review these changes before it goes in. (I'll look into it by the weekend)

sympy/functions/elementary/exponential.py

sympy/series/tests/test_series.py

anutosh491 · 2023-12-09T06:15:14Z

Thanks for your work. Once you address this, I'll point you to a couple more issues that we should be fixing.

sympy/functions/elementary/exponential.py

anutosh491 · 2023-12-10T03:26:49Z

The changes look good to me but I am not sure why does 1 test fail. It seems unrelated though. @oscarbenjamin could you help us out here ?

anutosh491 · 2023-12-10T06:15:05Z

cc @arnabnandikgp could you also squash these commits into 1 or 2 .Thanks

Signed-off-by: arnabnandikgp <arnabnandi2002@gmail.com>

sympy/series/tests/test_series.py

Signed-off-by: arnabnandikgp <arnabnandi2002@gmail.com>

arnabnandikgp force-pushed the issue_24266 branch from 2cd390d to 05cced9 Compare November 30, 2023 18:04

smichr reviewed Nov 30, 2023

View reviewed changes

sympy/functions/elementary/exponential.py Outdated Show resolved Hide resolved

smichr reviewed Nov 30, 2023

View reviewed changes

sympy/series/tests/test_series.py Show resolved Hide resolved

anutosh491 self-requested a review December 1, 2023 04:51

anutosh491 added the series label Dec 8, 2023

anutosh491 reviewed Dec 8, 2023

View reviewed changes

sympy/functions/elementary/exponential.py Outdated Show resolved Hide resolved

anutosh491 reviewed Dec 9, 2023

View reviewed changes

sympy/functions/elementary/exponential.py Outdated Show resolved Hide resolved

anutosh491 reviewed Dec 9, 2023

View reviewed changes

sympy/functions/elementary/exponential.py Show resolved Hide resolved

anutosh491 reviewed Dec 9, 2023

View reviewed changes

sympy/series/tests/test_series.py Show resolved Hide resolved

anutosh491 reviewed Dec 10, 2023

View reviewed changes

sympy/functions/elementary/exponential.py Outdated Show resolved Hide resolved

arnabnandikgp force-pushed the issue_24266 branch from dde83d5 to a134a43 Compare December 10, 2023 07:38

Changes for _eval_nseries in exp class for wrong outputs

6d80013

Signed-off-by: arnabnandikgp <arnabnandi2002@gmail.com>

arnabnandikgp force-pushed the issue_24266 branch from a134a43 to 6d80013 Compare December 10, 2023 07:50

anutosh491 reviewed Dec 10, 2023

View reviewed changes

sympy/series/tests/test_series.py Outdated Show resolved Hide resolved

anutosh491 reviewed Dec 10, 2023

View reviewed changes

sympy/series/tests/test_series.py Outdated Show resolved Hide resolved

minor changes

beddff5

Signed-off-by: arnabnandikgp <arnabnandi2002@gmail.com>

anutosh491 approved these changes Dec 10, 2023

View reviewed changes

anutosh491 enabled auto-merge December 10, 2023 11:29

anutosh491 merged commit 71c0b37 into sympy:master Dec 10, 2023

arnabnandikgp deleted the issue_24266 branch December 10, 2023 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Changes for _eval_nseries in exp class for wrong outputs #25943

Changes for _eval_nseries in exp class for wrong outputs #25943

Uh oh!

arnabnandikgp commented Nov 30, 2023

Uh oh!

sympy-bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

smichr commented Dec 1, 2023

Uh oh!

anutosh491 commented Dec 1, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anutosh491 commented Dec 9, 2023

Uh oh!

Uh oh!

anutosh491 commented Dec 10, 2023

Uh oh!

anutosh491 commented Dec 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Changes for _eval_nseries in exp class for wrong outputs #25943

Changes for _eval_nseries in exp class for wrong outputs #25943

Uh oh!

Conversation

arnabnandikgp commented Nov 30, 2023

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

Uh oh!

sympy-bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smichr commented Dec 1, 2023

Uh oh!

anutosh491 commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anutosh491 commented Dec 9, 2023

Uh oh!

Uh oh!

anutosh491 commented Dec 10, 2023

Uh oh!

anutosh491 commented Dec 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sympy-bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

anutosh491 commented Dec 1, 2023 •

edited

Loading