Skip to content

Conversation

PabloRuizCuevas
Copy link
Contributor

@PabloRuizCuevas PabloRuizCuevas commented Oct 23, 2023

Changed error messages that are wrong at validating hypergeometric distribution parameters, they were wrong and misleading, but is also not a super serious bug.

  • stats
    • Corrected minor errors in error messages of hypergeometric

Changed error messages that are wrong at validating hypergeometric distribution parameters
@sympy-bot
Copy link

sympy-bot commented Oct 23, 2023

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
Changed error messages that are wrong at validating hypergeometric distribution parameters, they were wrong and misleading, but is also not a super serious bug.

<!-- BEGIN RELEASE NOTES -->
* stats
  * Corrected minor errors in error messages of hypergeometric

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@PabloRuizCuevas PabloRuizCuevas changed the title Improved error messages at Hypergeometric distrigbution Improved error messages at Hypergeometric distribution Oct 23, 2023
@PabloRuizCuevas PabloRuizCuevas changed the title Improved error messages at Hypergeometric distribution Corrected error messages at Hypergeometric distribution Oct 23, 2023
this thing of the Mailmap is confusing, didn´t accept my previous mail
@PabloRuizCuevas
Copy link
Contributor Author

As offered #25794 here i could also take the opportunity of taking out % and format them with f-strings

@PabloRuizCuevas
Copy link
Contributor Author

The test errors are completely unrelated to my pr

@smichr
Copy link
Member

smichr commented Oct 23, 2023

Looks good. No need to convert. Also, str(n) is not needed to pass into the string

>>> 'n=%s'%3
'n=3'

@smichr smichr merged commit b6e3fd5 into sympy:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants