Skip to content

[GSOC_2.4] Support phase unwrapping in frequency response #25463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2023
Merged

[GSOC_2.4] Support phase unwrapping in frequency response #25463

merged 2 commits into from
Aug 15, 2023

Conversation

faze-geek
Copy link
Contributor

References to other Issues or PRs

Fixes #25444

Brief description of what is fixed or changed

Other comments

Release Notes

  • physics.control
    • Added support for phase unwrap in bode plot

@sympy-bot
Copy link

sympy-bot commented Aug 2, 2023 •
edited
Loading

✅

Hi, I am the SymPy bot (v170). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.control

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #25444 

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.control
  * Added support for phase unwrap in bode plot
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@faze-geek faze-geek added the GSoC label Aug 2, 2023
Davide-sd
Davide-sd reviewed Aug 2, 2023
View reviewed changes
@faze-geek faze-geek closed this Aug 6, 2023
@faze-geek faze-geek reopened this Aug 6, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited
Loading

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [8059df73]       [77010f3b]
     <sympy-1.12^0>                 
-         113±3ms         71.4±1ms     0.63  integrate.TimeIntegrationRisch02.time_doit(10)
-         109±2ms       70.5±0.7ms     0.65  integrate.TimeIntegrationRisch02.time_doit_risch(10)
-     2.69±0.07ms         782±20μs     0.29  polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')
-      12.7±0.4ms      2.28±0.02ms     0.18  polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')
-         425±5μs         93.4±2μs     0.22  polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')
-     5.88±0.05ms         430±10μs     0.07  polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')
-      13.0±0.3ms      1.23±0.03ms     0.09  polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')
-      7.51±0.1ms      4.56±0.05ms     0.61  polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse')
-      33.0±0.2ms       14.0±0.2ms     0.42  polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse')
-      8.03±0.1ms      1.37±0.02ms     0.17  polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')
-      18.5±0.3ms       10.7±0.3ms     0.58  polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')
-         246±4ms         80.8±1ms     0.33  polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')
-      8.07±0.1ms          652±4μs     0.08  polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')
-      34.9±0.4ms      1.02±0.02ms     0.03  polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')
-        721±10μs          259±5μs     0.36  polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse')
-      7.98±0.1ms          260±4μs     0.03  polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse')
-      21.4±0.7ms          261±6μs     0.01  polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse')
-         211±4μs          117±1μs     0.55  solve.TimeMatrixOperations.time_rref(3, 0)
-         399±8μs          139±3μs     0.35  solve.TimeMatrixOperations.time_rref(4, 0)
-      37.9±0.4ms       16.1±0.5ms     0.42  solve.TimeSolveLinSys189x49.time_solve_lin_sys



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
        

  

      

  smichr
  

  
          

            
                  smichr
  

            

            reviewed


            
                
                  Aug 15, 2023
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
        

  

      

  smichr
  

  
          

            
                  smichr
  

            

            reviewed


            
                
                  Aug 15, 2023
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
        





      

  
          
 
  

    
  

  



        @smichr
  smichr



        merged commit 456d56a
      into

      
  
    sympy:master
  


    Aug 15, 2023

  
















  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @smichr
  
    smichr



    
      
        
      
    
    smichr left review comments

  


        

    


  
      @moorepants
  
    moorepants



    
      
        
      
    
    moorepants left review comments

  


        

    


  
      @Sc0rpi0n101
  
    Sc0rpi0n101



    
      
        
      
    
    Sc0rpi0n101 approved these changes

  



      

        
          +1 more reviewer
          
          
        
          

              

    


  
      @Davide-sd
  
    Davide-sd



    
      
        
      
    
    Davide-sd left review comments

  


          

      

      Reviewers whose approvals may not affect merge requirements
      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    GSoC









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.



  
          
      Need for phase unwrapping.



  
  



      
    

  




      

    

  
      

  

    

      6 participants
    

    

        
          @faze-geek 
        
          @sympy-bot 
        
          @smichr 
        
          @moorepants 
        
          @Davide-sd 
        
          @Sc0rpi0n101