Skip to content

Conversation

tjstienstra
Copy link
Contributor

@tjstienstra tjstienstra commented Mar 6, 2023

References to other Issues or PRs

Implements #24864

Brief description of what is fixed or changed

Implement the support of taking a derivative of a MatrixSolve node.

Other comments

Release Notes

  • codegen
    • Implemented diff support for MatrixSolve.

@tjstienstra tjstienstra added the CZI: Codegen/Biomech Sam Brockie's CZI-funded postdoc work on codegen and biomechanics label Mar 6, 2023
@tjstienstra tjstienstra requested a review from brocksam March 6, 2023 16:15
@sympy-bot
Copy link

sympy-bot commented Mar 6, 2023

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Implements #24864

#### Brief description of what is fixed or changed
Implement the support of taking a derivative of a `MatrixSolve` node.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* codegen
  * Implemented diff support for `MatrixSolve`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

Copy link
Contributor

@brocksam brocksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And great addition of really useful functionality! Thanks!

Copy link
Contributor

@brocksam brocksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the extra blank lines at end of file removed for the code quality check to pass though.

@moorepants
Copy link
Member

Nice addition! LGTM too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CZI: Codegen/Biomech Sam Brockie's CZI-funded postdoc work on codegen and biomechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants