Skip to content

Particle and RigidBody compatibility with the joints framework #24830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 9, 2023
Merged

Particle and RigidBody compatibility with the joints framework #24830

merged 6 commits into from
Mar 9, 2023

Conversation

tjstienstra
Copy link
Contributor

References to other Issues or PRs

Output of the mechanics experimental development (#24234)
Implements parts of #24550 and #24699

Brief description of what is fixed or changed

Make Particle and RigidBody compatible with the joints framework.

Other comments

Release Notes

  • physics.mechanics
    • Make Particle and RigidBody compatible with the joints framework.

@tjstienstra tjstienstra requested a review from brocksam March 2, 2023 18:29
@tjstienstra tjstienstra requested a review from moorepants as a code owner March 2, 2023 18:29
@sympy-bot
Copy link

sympy-bot commented Mar 2, 2023 •
edited
Loading

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.mechanics
    • Make Particle and RigidBody compatible with the joints framework. (#24830 by @TJStienstra)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Output of the mechanics experimental development (#24234)
Implements parts of #24550 and #24699

#### Brief description of what is fixed or changed
Make `Particle` and `RigidBody` compatible with the joints framework.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.mechanics
  * Make `Particle` and `RigidBody` compatible with the joints framework.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)




Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        

  

      

  brocksam
  

  
          

            
                  brocksam
  

            

            approved these changes


            
                
                  Mar 3, 2023
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      @brocksam

      
            brocksam
  

      

      

      left a comment




      
    


  



                  

                      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Extensive review by me has taken place on #24550 and #24699.

    

  
  




                    

                  
  
  

    
  
    
    

  

  

  



                      

                    
                  








      

  
  
  




  








      

  
      



  

  @brocksam





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            brocksam
  

      

      

      commented


        Mar 6, 2023


      
    


  





      


        



  
    

      
          
I will merge soon if nobody else has any comments they'd like to add.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          
 
  

    
  

  



        @brocksam
  brocksam



        merged commit 074c228
      into

      
  
    sympy:master
  


    Mar 9, 2023

  







    

    

      
    

    


      


          @moorepants
moorepants




          added
  the 

  CZI: Codegen/Biomech

  Sam Brockie's CZI-funded postdoc work on codegen and biomechanics
 label


      Apr 22, 2023

    

  












  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @brocksam
  
    brocksam



    
      
        
      
    
    brocksam approved these changes

  


      

          


  
      @moorepants
  
    moorepants


                Awaiting requested review from moorepants

                    moorepants is a code owner

        
      


      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    CZI: Codegen/Biomech

  Sam Brockie's CZI-funded postdoc work on codegen and biomechanics
  

    physics.mechanics









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @tjstienstra 
        
          @sympy-bot 
        
          @brocksam 
        
          @moorepants