Add config option diff_operator in latex printer #23239
Merged
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hi, I am the SymPy bot (v163). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
|
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[907895ac] [ebda8eb8]
- 243±1ms 150±2ms 0.61 large_exprs.TimeLargeExpressionOperations.time_subs
- 257±0.9μs 121±2μs 0.47 matrices.TimeMatrixExpression.time_MatMul
- 16.2±0.03ms 8.57±0.3ms 0.53 matrices.TimeMatrixExpression.time_MatMul_doit
- 4.84±0.01s 355±4ms 0.07 polygon.PolygonArbitraryPoint.time_bench01
+ 3.78±0.02ms 6.47±0.07ms 1.71 solve.TimeMatrixOperations.time_det(4, 2)
+ 3.84±0.04ms 6.60±0.1ms 1.72 solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+ 43.4±0.2ms 75.2±0.8ms 1.73 solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+ 44.0±0.3ms 77.0±0.9ms 1.75 solve.TimeMatrixSolvePyDySlow.time_solve(1)
Full benchmark results can be found as artifacts in GitHub Actions |
oscargus
reviewed
Mar 14, 2022
oscargus
reviewed
Mar 14, 2022
|
|
||
| # Only up to \iiiint exists | ||
| if len(expr.limits) <= 4 and all(len(lim) == 1 for lim in expr.limits): | ||
| # Use len(expr.limits)-1 so that syntax highlighters don't think | ||
| # \" is an escaped quote | ||
| tex = r"\i" + "i"*(len(expr.limits) - 1) + "nt" | ||
| symbols = [r"\, d%s" % self._print(symbol[0]) | ||
| symbols = [r"\, %s%s" % (diff_symbol, self._print(symbol[0])) |
There was a problem hiding this comment.
Good that you also considered Integral.
98ce2d1 to
e499990
Compare
e499990 to
d7ed287
Compare
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Closes #23226
Similar to #15936, so maybe @oscargus could review it.
Brief description of what is fixed or changed
Allow passing
diff_operatorto latex printer. The default behavior (italic d) is not changed. Shortcuts'rd'and'td'are added for convenience.Other comments
Release Notes