Skip to content

allow collect to work with compound generators #23757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

allow collect to work with compound generators #23757

merged 1 commit into from
Jul 11, 2022

Conversation

smichr
Copy link
Member

@smichr smichr commented Jul 11, 2022 •
edited
Loading

References to other Issues or PRs

Brief description of what is fixed or changed

now:

>>> collect(x+a*x+x*y+b*x*y+y+3*y,[x,y],exact=None)
x*y*(b + 1) + x*(a + 1) + 4*y
>>> ^Z

master:

>>> collect(x+a*x+x*y+b*x*y+y+3*y,[x,y],exact=None)
x*(a + b*y + y + 1) + 4*y

Other comments

Release Notes

  • simplify
    • collect will now allow collection of coefficients in products of generators to be collected when exact=None

@sympy-bot
Copy link

sympy-bot commented Jul 11, 2022 •
edited
Loading

✅

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • simplify
    • collect will now allow collection of coefficients in products of generators to be collected when exact=None (#23757 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

now:
```python
>>> collect(x+a*x+x*y+b*x*y+y+3*y,[x,y],exact=None)
x*y*(b + 1) + x*(a + 1) + 4*y
>>> ^Z
```

master:
```python
>>> collect(x+a*x+x*y+b*x*y+y+3*y,[x,y],exact=None)
x*(a + b*y + y + 1) + 4*y
```
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* simplify
  * `collect` will now allow collection of coefficients in products of generators to be collected when exact=None
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr
Copy link
Member Author

smichr commented Jul 11, 2022

blocking #23699

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [77f1d79c]       [edf24253]
     <sympy-1.10.1^0>                 
+         136±5ms          219±8ms     1.61  sum.TimeSum.time_doit



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @oscarbenjamin





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        



  
    

      
          
Looks good to me

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  



        @smichr
  smichr



        merged commit cace087
      into

      
  
    sympy:master
  


    Jul 11, 2022

  







  

  
  

  
      @smichr
  smichr


    
    deleted the
    
      
        collect
    
    branch

    July 11, 2022 15:12    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @smichr 
        
          @sympy-bot 
        
          @oscarbenjamin