Skip to content

allow lim_{x\to3^-} #23756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

allow lim_{x\to3^-} #23756

merged 1 commit into from
Jul 12, 2022

Conversation

eagleoflqj
Copy link
Member

References to other Issues or PRs

Brief description of what is fixed or changed

This latex is fine but gives a parsing error because limit direction doesn't have braces
$$\lim_{x\to3^-}\frac{1}{x-3}$$

from sympy.parsing.latex import parse_latex
parse_latex(R'\lim_{x\to3^-}\frac{1}{x-3}')

Other comments

https://sympy-beta.vercel.app/latex/\lim_{x\to3^-}\frac{1}{x-3}
I'd like to include it in SymPy 1.11 as mathlive (which I'm trying to integrate into SymPy Beta) doesn't seem to have a workaround to insert ^{-} with the {} kept.

Release Notes

  • parsing
    • Latex parser allows limit direction without braces

@eagleoflqj eagleoflqj added this to the SymPy 1.11 milestone Jul 10, 2022
@eagleoflqj eagleoflqj requested review from asmeurer and oscargus July 10, 2022 23:53
@sympy-bot
Copy link

sympy-bot commented Jul 10, 2022 •
edited
Loading

✅

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
This latex is fine but gives a parsing error because limit direction doesn't have braces
$$\lim_{x\to3^-}\frac{1}{x-3}$$
```
from sympy.parsing.latex import parse_latex
parse_latex(R'\lim_{x\to3^-}\frac{1}{x-3}')
```
#### Other comments
https://sympy-beta.vercel.app/latex/\lim_{x\to3^-}\frac{1}{x-3}
I'd like to include it in SymPy 1.11 as [mathlive](https://github.com/arnog/mathlive) (which I'm trying to integrate into SymPy Beta) doesn't seem to have a workaround to insert `^{-}` with the `{}` kept.
#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* parsing
  * Latex parser allows limit direction without braces
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [77f1d79c]       [edf24253]
     <sympy-1.10.1^0>                 
+       117±0.3ms        208±0.5ms     1.78  sum.TimeSum.time_doit



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          
 
  

    
  

  



        @eagleoflqj
  eagleoflqj



        merged commit de24949
      into

      
  
    sympy:master
  


    Jul 12, 2022

  







  

  
  

  
      @eagleoflqj
  eagleoflqj


    
    deleted the
    
      
        latex_lim_dir
    
    branch

    July 12, 2022 09:40    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @oscargus
  
    oscargus



    
      
        
      
    
    oscargus approved these changes

  


      

          


  
      @asmeurer
  
    asmeurer


                Awaiting requested review from asmeurer


        
      


      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    parsing.latex









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    SymPy 1.11
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @eagleoflqj 
        
          @sympy-bot 
        
          @oscargus