Skip to content

manualintegrate DiracDelta #23670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

manualintegrate DiracDelta #23670

merged 2 commits into from
Jun 23, 2022

Conversation

eagleoflqj
Copy link
Member

References to other Issues or PRs

#23559 (comment)

Brief description of what is fixed or changed

  • Previously when arg has no minus sign, DiracDelta(..., 0) doesn't evaluate to DiracDelta(...)
  • Support manual integrate DiracDelta(a+b*x, n)

Other comments

Release Notes

  • functions
    • Auto evaluate DiracDelta(x, 0) to DiracDelta(x)
  • integrals
    • Support integral steps for DiracDelta

@sympy-bot
Copy link

sympy-bot commented Jun 23, 2022 •
edited
Loading

✅

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

https://github.com/sympy/sympy/pull/23559#issuecomment-1163794267
#### Brief description of what is fixed or changed

* Previously when arg has no minus sign, `DiracDelta(..., 0)` doesn't evaluate to `DiracDelta(...)`
* Support manual integrate `DiracDelta(a+b*x, n)`
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
  * Auto evaluate DiracDelta(x, 0) to DiracDelta(x)
* integrals
  * Support integral steps for DiracDelta
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [77f1d79c]       [f5114602]
     <sympy-1.10.1^0>                 
+      96.8±0.8ms        177±0.5ms     1.83  sum.TimeSum.time_doit



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        

  

      

  oscargus
  

  
          

            
                  oscargus
  

            

            reviewed


            
                
                  Jun 23, 2022
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

              

          
                sympy/functions/special/delta_functions.py

              
                Outdated
          
        


      
          
  

    
      
    
    

          

            
            
            @@ -230,6 +230,8 @@ class is about to be instantiated and it returns either some simplified
          

          


              

              

            
                              return -cls(-arg, k)

            
          

          


              

              

            
                          elif k.is_even:

            
          

          


              

              

            
                              return cls(-arg, k) if k else cls(-arg)

            
          

          


              

              

            
                      elif k == 0:

            
          

    








  

    

        

        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      @oscargus

      
            oscargus
  

      

      

      


        Jun 23, 2022


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
  
        
      Loading


  
    
  



    


  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

        

    

      

        Suggested change
      

    

    

      

          

            
                    elif k == 0:
          

          

            
                    elif k.is_zero:
          

      

    

    

  



?

    

  
  



    


        

      
  
  

    
  
    
    

  

  

  



          

      
    





    

        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
We know it is an Integer already. (And this is faster with no drawbacks.)

    

  
  



    


        

      
  
  

    
  
    
    

  

  

  



          

      
    








    


  









  








  








      

  
      



  

  @jksuom





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            jksuom
  

      

      

      commented


        Jun 23, 2022


      
    


  





      


        



  
    

      
          
Looks good to me.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          

  
  

  
      @eagleoflqj
  eagleoflqj


        force-pushed
    the
        
      
  manualintegrate_diracdelta


    
 branch
    from
    3531241    to
    6e5e984      
    Compare
  



    June 23, 2022 22:13    
    




  

  
  

  
    
            @eagleoflqj
  eagleoflqj

enabled auto-merge

    June 23, 2022 22:13    
    




  
 
  

    
  

  



        @eagleoflqj
  eagleoflqj



        merged commit e2d5814
      into

      
  
    sympy:master
  


    Jun 23, 2022

  







  

  
  

  
      @eagleoflqj
  eagleoflqj


    
    deleted the
    
      
        manualintegrate_diracdelta
    
    branch

    June 23, 2022 23:53    
    




  

  

    
  


  

      


    @eagleoflqj
eagleoflqj



    mentioned this pull request
    
      Jun 24, 2022
    





  


  

      
     Merged

  







  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @oscargus
  
    oscargus



    
      
        
      
    
    oscargus left review comments

  


      

          


  
      @jksuom
  
    jksuom


                Awaiting requested review from jksuom


        
      

      

          


  
      @oscarbenjamin
  
    oscarbenjamin


                Awaiting requested review from oscarbenjamin


        
      


      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    integrals.manualintegrate









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @eagleoflqj 
        
          @sympy-bot 
        
          @jksuom 
        
          @oscargus