-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
maint(printing): remove deprecated stub submodules #23660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
🟠Hi, I am the SymPy bot (v167). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits delete files:
If these files were added/deleted on purpose, you can ignore this message. |
@asmeurer what should we do with the list of deprecations in this case? https://docs.sympy.org/dev/explanation/active-deprecations.html Do we just remove this entry? Or should there be another entry for things that are now removed or something? |
The ccode, cxxcode and fcode modules were deprecated because their names conflict with the functions defined within them leading to import ambiguity. The change here removes the modules altogether because testing the deprecated behaviour still leads to import ambiguity in the test suite.
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [596257ec]
<sympy-1.10.1^0>
+ 93.3±5ms 179±0.9ms 1.92 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
I'd say just remove it from the active list once the deprecation is removed. For historic changes, there is the release notes. |
I meant to resolve that before merging. I'll open a new PR... |
The ccode, cxxcode and fcode modules were deprecated because their names
conflict with the functions defined within them leading to import
ambiguity. The change here removes the modules altogether because
testing the deprecated behaviour still leads to import ambiguity in the
test suite.
References to other Issues or PRs
Fixes #23533
Brief description of what is fixed or changed
Remove the ccode, fcode and cxxcode deprecated submodules and the tests for the deprecated functionality.
Other comments
Release Notes
sympy.printing.ccode
,sympy.printing.cxxcode
andsympy.printing.fcode
have been removed. These modules were renamed to e.g.sympy.printing.c
in SymPy 1.7 but deprecated stub modules were left behind to give a warning to anyone doingfrom sympy.printing.ccode import ccode
that they should change their imports. Those deprecated stub modules are now removed. The reason for this change was because of ambiguity when writingfrom sympy.printing import ccode
which might import theccode
submodule or theccode
function defined in the submodule. Even continuing to test these deprecated stub modules caused problems in the test suite precisely because of this ambiguity so the modules are now removed completely. The functions that used to be defined in these modules are still available as e.g.from sympy import ccode, cxxcode, fcode
(as they have been since before 1.7).