Skip to content

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Apr 24, 2022

References to other Issues or PRs

Brief description of what is fixed or changed

Add build script for autolev antlr4 parser, derived from the latex one.

Other comments

Release Notes

  • parsing
    • add script for rebuilding autolev antlr parser

@sympy-bot
Copy link

sympy-bot commented Apr 24, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • parsing
    • add script for rebuilding autolev antlr parser (#23416 by @xrmx)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

Add build script for autolev antlr4 parser, derived from the latex one.

#### Other comments


#### Release Notes

<!-- BEGIN RELEASE NOTES -->

* parsing
   * add script for rebuilding autolev antlr parser

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@sympy-bot
Copy link

sympy-bot commented Apr 24, 2022

🟠

Hi, I am the SymPy bot (v167). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits add new files:

  • 196b69a:
    • sympy/parsing/autolev/_build_autolev_antlr.py

If these files were added/deleted on purpose, you can ignore this message.

xrmx added 2 commits April 24, 2022 18:32
When calling the antlr command build the autolev parser too.
@xrmx xrmx force-pushed the add-autolev-parser-build-machinery branch from 511bd81 to bf12070 Compare April 24, 2022 16:32
@github-actions
Copy link

github-actions bot commented Apr 24, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [c950ad69]
     <sympy-1.10.1^0>                 
+      97.1±0.3ms        177±0.7ms     1.82  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@eagleoflqj
Copy link
Member

I'm a little surprised that it's not already implemented, but given the generated files have only one author it seems explainable.

@eagleoflqj eagleoflqj closed this Jun 29, 2022
@eagleoflqj eagleoflqj reopened this Jun 29, 2022
@eagleoflqj eagleoflqj self-assigned this Jun 29, 2022
@eagleoflqj
Copy link
Member

Tested locally. The generated files only have white space and header comment changes with origin.
Thank you!

@eagleoflqj eagleoflqj merged commit 34db00e into sympy:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants