-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
22453a: (oo + I*oo)**(not 0 or 1) -> nan #22516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[907895ac] [fd93490a]
- 4.76±0s 299±2ms 0.06 polygon.PolygonArbitraryPoint.time_bench01
Full benchmark results can be found as artifacts in GitHub Actions |
Shouldn't |
Checking with semi-finite versions, the issue also arises >>> 1/(oo+3*I)
0*(oo - 3*I)
>>> (oo+3*I)*(oo-3*I)
(oo - 3*I)*(oo + 3*I)
>>> expand(_)
nan
>>> 1/(3+I*oo)
0*(3 - oo*I)
>>> (3+oo*I)*(3-oo*I)
(3 - oo*I)*(3 + oo*I)
>>> expand(_)
nan |
Any objections? |
and for negative exponents , |
@eagleoflqj , @jksuom -- does this look right now? And is this right to all exponents of +/-oo to give results similar to +/-2 (finite version)? |
This looks good to me. |
Thanks @jksuom |
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
This is in response to an inline comment in
test_add_flatten
which noted that1/(oo + I*oo) -> 0*(oo - I*oo)
.Release Notes