Skip to content

Conversation

sweeneyde
Copy link
Contributor

@sweeneyde sweeneyde commented Nov 6, 2021

References to other Issues or PRs

Brief description of what is fixed or changed

With Python's big boxed integers, using one "<<" and one "&" is faster than two multiplications and two "&"s. Also added stronger filters, letting only 0.425% of cases get to the integer_nthroot computation.

Other comments

Benchmarks:

from timeit import timeit
R = range(2_000_000)
x = timeit(lambda: sum(my_is_square(x, False) for x in R), number=3)
y = timeit(lambda: sum(sympy_is_square(x, False) for x in R), number=3)
print(x) # 1.632436300162226
print(y) # 2.681206800043583

Release Notes

  • ntheory
    • Improved the performance of the is_square(n) function.

@sympy-bot
Copy link

sympy-bot commented Nov 6, 2021

Hi, I am the SymPy bot (v162). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • ntheory

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

With Python's big boxed integers, using one "<<" and one "&" is faster than two multiplications and two "&"s. Also added stronger filters, letting only 0.425% of cases get to the integer_nthroot computation.

#### Other comments

Benchmarks:
```python
from timeit import timeit
R = range(2_000_000)
x = timeit(lambda: sum(my_is_square(x, False) for x in R), number=3)
y = timeit(lambda: sum(sympy_is_square(x, False) for x in R), number=3)
print(x) # 1.632436300162226
print(y) # 2.681206800043583
```

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* ntheory
  * Improved the performance of the `is_square(n)` function.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Nov 6, 2021

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [3a49fc4d]
-      4.92±0.07s          310±4ms     0.06  polygon.PolygonArbitraryPoint.time_bench01

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr
Copy link
Member

smichr commented Nov 6, 2021

Looks good, thanks!

@smichr smichr merged commit 6247eef into sympy:master Nov 6, 2021
@smichr
Copy link
Member

smichr commented Nov 6, 2021

I confirmed that both sums over range(2*10**6) indicate 1415 squares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants