Skip to content

21303: do not canonicalize imageset with Floats #21313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

21303: do not canonicalize imageset with Floats #21313

merged 2 commits into from
Apr 13, 2021

Conversation

smichr
Copy link
Member

@smichr smichr commented Apr 13, 2021

References to other Issues or PRs

fixes #21303

Brief description of what is fixed or changed

When imageset on integers has a linear expression, that expression is made canonical by shifting the origin. This should not be done so when there are Floats present as this may result in the constant term not appearing in the set as shown in #21303.

Other comments

Release Notes

  • sets
    • imageset involving Integers will not make linear expressions canonical when they contain Floats

@sympy-bot
Copy link

sympy-bot commented Apr 13, 2021 •
edited
Loading

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • sets
    • imageset involving Integers will not make linear expressions canonical when they contain Floats (#21313 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

fixes #21303

#### Brief description of what is fixed or changed

When imageset on integers has a linear expression, that expression is made canonical by shifting the origin. This should not be done so when there are Floats present as this may result in the constant term not appearing in the set as shown in #21303.

#### Other comments


#### Release Notes

<!-- BEGIN RELEASE NOTES -->
* sets
  * imageset involving Integers will not make linear expressions canonical when they contain Floats
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

oscarbenjamin
oscarbenjamin reviewed Apr 13, 2021
View reviewed changes
@oscarbenjamin
Copy link
Collaborator

Looks good to me

@smichr smichr merged commit d098ab3 into sympy:master Apr 13, 2021
@smichr smichr deleted the can-image branch April 13, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarbenjamin oscarbenjamin oscarbenjamin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't canonicalize imageset based on Float
3 participants
@smichr @sympy-bot @oscarbenjamin