Skip to content

feat(polys): allow DomainMatrix to be dense or sparse #21140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(polys): allow DomainMatrix to be dense or sparse #21140

wants to merge 1 commit into from

Conversation

oscarbenjamin
Copy link
Collaborator

The DomainMatrix class was originally introduces with DDM as its
internal representation representing a dense internal format. The SDM
sparse format was added later and made to be the internal format of DDM
always. This commit makes it possible DomainMatrix to use either SDM or
DDM as its internal format in the constructor by passing fmt="dense" or
fmt="sparse".

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@oscarbenjamin
feat(polys): allow DomainMatrix to be dense or sparse
d84b20d 
The DomainMatrix class was originally introduces with DDM as its
internal representation representing a dense internal format. The SDM
sparse format was added later and made to be the internal format of DDM
always. This commit makes it possible DomainMatrix to use either SDM or
DDM as its internal format in the constructor by passing fmt="dense" or
fmt="sparse".
@sympy-bot
Copy link

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed. 
The DomainMatrix class was originally introduces with DDM as its
internal representation representing a dense internal format. The SDM
sparse format was added later and made to be the internal format of DDM
always. This commit makes it possible DomainMatrix to use either SDM or
DDM as its internal format in the constructor by passing fmt="dense" or
fmt="sparse".

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@oscarbenjamin oscarbenjamin mentioned this pull request Mar 21, 2021
Merged
@oscarbenjamin
Copy link
Collaborator Author

If anyone wants to take over and finish this PR then go ahead.

  1. It needs tests.
  2. There should be a quick way to convert a DomainMatrix from one representation to another (perhaps to_sparse()/to_dense() or to_fmt('sparse').
  3. There needs to be some logic for handling binary operations between dense and sparse DomainMatrix (maybe unify() can do this)
  4. Potentially there could be some mixed operations where it makes sense like sparse matrix multiplying a dense column vector (although those could be for another PR).

@oscarbenjamin oscarbenjamin mentioned this pull request Mar 21, 2021
Open
@ks147
Copy link
Contributor

ks147 commented Mar 21, 2021 •
edited
Loading

If anyone wants to take over and finish this PR then go ahead.

  1. It needs tests.
  2. There should be a quick way to convert a DomainMatrix from one representation to another (perhaps to_sparse()/to_dense() or to_fmt('sparse').
  3. There needs to be some logic for handling binary operations between dense and sparse DomainMatrix (maybe unify() can do this)
  4. Potentially there could be some mixed operations where it makes sense like sparse matrix multiplying a dense column vector (although those could be for another PR).

I am willing to take over. I'll try and finish this PR

@ks147 ks147 mentioned this pull request Mar 22, 2021
Merged
@oscarbenjamin
Copy link
Collaborator Author

Superseded by #21146

@oscarbenjamin oscarbenjamin deleted the pr_dm_dense_sparse branch April 7, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
polys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscarbenjamin @sympy-bot @ks147 @Abdullahjavednesar