Skip to content

iterables - fixes issue 21863 and now multiset_permutations can handle [] #21864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2021
Merged

iterables - fixes issue 21863 and now multiset_permutations can handle [] #21864

merged 2 commits into from
Aug 13, 2021

Conversation

praneethratna
Copy link
Contributor

References to other Issues or PRs

Brief description of what is fixed or changed

Fixes #21863 and now multiset_permutations can handle null/empty sets and also added regression tests in test_iterables.py

Other comments

Release Notes

  • utilities
    • Fixed bug in iterables.py and now multiset_permutations can handle []

@sympy-bot
Copy link

sympy-bot commented Aug 12, 2021 •
edited
Loading

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Fixes #21863 and now multiset_permutations can handle null/empty sets and also added regression tests in test_iterables.py

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* utilities
    * Fixed bug in iterables.py and now multiset_permutations can handle []
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [ed9a550f]       [ec0fe8c5]
     <sympy-1.8^0>                 
-      1.18±0.01s          154±3ms     0.13  dsolve.TimeDsolve01.time_dsolve
-      10.3±0.02s       4.89±0.03s     0.47  integrate.TimeIntegrationRisch02.time_doit_risch(100)
+       123±0.9ms          190±4ms     1.54  logic.LogicSuite.time_dpll2
-      83.8±0.7μs         33.6±1μs     0.40  matrices.TimeDiagonalEigenvals.time_eigenvals
-         107±3μs         68.0±4μs     0.63  matrices.TimeMatrixGetItem.time_ImmutableDenseMatrix_getitem
-         114±2μs         67.3±3μs     0.59  matrices.TimeMatrixGetItem.time_ImmutableSparseMatrix_getitem
-         104±3μs       64.7±0.6μs     0.62  matrices.TimeMatrixGetItem.time_MutableDenseMatrix_getitem
-         111±2μs         64.2±1μs     0.58  matrices.TimeMatrixGetItem.time_MutableSparseMatrix_getitem
-         103±4μs       56.0±0.6μs     0.54  solve.TimeMatrixArithmetic.time_dense_add(10, 0)
+      13.2±0.5μs       23.5±0.6μs     1.78  solve.TimeMatrixArithmetic.time_dense_add(3, 0)
+      15.6±0.6μs       34.4±0.4μs     2.21  solve.TimeMatrixArithmetic.time_dense_add(3, 5)
+      24.8±0.3μs       47.5±0.6μs     1.92  solve.TimeMatrixArithmetic.time_dense_add(4, 5)
+        43.7±2μs         72.7±2μs     1.66  solve.TimeMatrixArithmetic.time_dense_add(6, 5)
-     1.45±0.07ms          251±6μs     0.17  solve.TimeMatrixArithmetic.time_dense_multiply(10, 0)
-        58.7±2μs       29.3±0.5μs     0.50  solve.TimeMatrixArithmetic.time_dense_multiply(3, 0)
+        90.1±1μs          149±3μs     1.66  solve.TimeMatrixArithmetic.time_dense_multiply(3, 5)
-         127±8μs       35.3±0.3μs     0.28  solve.TimeMatrixArithmetic.time_dense_multiply(4, 0)
-         353±9μs         69.7±2μs     0.20  solve.TimeMatrixArithmetic.time_dense_multiply(6, 0)
-         114±5μs       52.9±0.9μs     0.46  solve.TimeMatrixOperations.time_det(3, 0)
-         194±8μs          115±6μs     0.59  solve.TimeMatrixOperations.time_det(3, 2)
-         194±4μs          108±2μs     0.56  solve.TimeMatrixOperations.time_det(3, 5)
-         106±2μs         52.9±2μs     0.50  solve.TimeMatrixOperations.time_det_bareiss(3, 0)
-         198±3μs          113±2μs     0.57  solve.TimeMatrixOperations.time_det_bareiss(3, 2)
-         199±2μs          112±1μs     0.56  solve.TimeMatrixOperations.time_det_bareiss(3, 5)
-         109±8μs         50.2±2μs     0.46  solve.TimeMatrixOperations.time_det_berkowitz(3, 0)
-        207±20μs          114±3μs     0.55  solve.TimeMatrixOperations.time_det_berkowitz(3, 2)
-         193±4μs          105±3μs     0.54  solve.TimeMatrixOperations.time_det_berkowitz(3, 5)
+        859±50μs      1.33±0.09ms     1.55  solve.TimeMatrixOperations.time_det_berkowitz(4, 0)
+     1.00±0.04ms      1.86±0.04ms     1.86  solve.TimeMatrixOperations.time_det_berkowitz(4, 2)
+     1.06±0.05ms      1.98±0.04ms     1.87  solve.TimeMatrixOperations.time_det_berkowitz(4, 5)
+        321±10μs          512±7μs     1.59  solve.TimeMatrixOperations.time_rank(3, 0)
+        503±20μs         822±20μs     1.63  solve.TimeMatrixOperations.time_rank(4, 0)
-      5.88±0.2ms      3.32±0.07ms     0.56  solve.TimeRationalSystem.time_linsolve(10)
-     1.24±0.06ms         783±40μs     0.63  solve.TimeRationalSystem.time_linsolve(5)
-     1.43±0.07ms          874±5μs     0.61  solve.TimeSparseSystem.time_linsolve_eqs(10)
-     2.68±0.07ms      1.62±0.05ms     0.60  solve.TimeSparseSystem.time_linsolve_eqs(20)
-      3.76±0.2ms      2.32±0.09ms     0.62  solve.TimeSparseSystem.time_linsolve_eqs(30)



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        

  

      

  smichr
  

  
          

            
                  smichr
  

            

            reviewed


            
                
                  Aug 13, 2021
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
        

  

      

  smichr
  

  
          

            
                  smichr
  

            

            reviewed


            
                
                  Aug 13, 2021
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
        





      

  
      



  

  @smichr





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            smichr
  

      

      

      commented


        Aug 13, 2021


      
    


  





      


        



  
    

      
          
@praneethratna , please check changes if tests pass

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @praneethratna





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        



  
    

      
          


@praneethratna , please check changes if tests pass




@smichr everything is fine and this PR can be merged i guess.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  



        @smichr
  smichr



        merged commit 4b94033
      into

      
  
    sympy:master
  


    Aug 13, 2021

  












      

  
      



  

  @smichr





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            smichr
  

      

      

      commented


        Aug 13, 2021


      
    


  





      


        



  
    

      
          
Thanks, it's in.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @praneethratna
  praneethratna


    
    deleted the
    
      
        21863_iterables
    
    branch

    August 13, 2021 16:23    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @smichr
  
    smichr



    
      
        
      
    
    smichr left review comments

  



      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.



  
          
      multiset_permutations needs to handle []



  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @praneethratna 
        
          @sympy-bot 
        
          @smichr