Skip to content

[GSoC] Limit bug fixes #21775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 25, 2021
Merged

[GSoC] Limit bug fixes #21775

merged 9 commits into from
Jul 25, 2021

Conversation

0sidharth
Copy link
Member

@0sidharth 0sidharth commented Jul 24, 2021 •
edited
Loading

References to other Issues or PRs

Fixes #9497
Fixes #18363
Fixes #21598
Fixes #21756

Brief description of what is fixed or changed

Other comments

Release Notes

  • functions
    • Added polylog nseries expansion
    • Fixes bug in erf nseries expansion leading to wrong number of terms
    • log leading term method handles zoo better, thus raises more often
    • binomial leading term method added
  • series
    • Limit now throws NotImplementedError if the point contains the variable wrt which limit is being found

0sidharth added 6 commits July 24, 2021 14:54
@0sidharth
Added polylog _eval_nseries
0ff6eb2
@0sidharth
error functions: fixed bugs leading to incorrect no. of terms and is_…
d466838 
…negative check of integers
@0sidharth
log._eval_as_leading_term handles zoo better
ac76fc0 
Add._eval_as_leading_term piecewise_folds Piecewise expressions (sympy#18363)
@0sidharth
Limit.doit leadterm block now handles factorial and binomial
25dbd7b 
binomial._eval_as_leading_term method added

Limit.doit is_Pow heuristics moved to separate function, and called only
when leadterm fails, some unneeded clauses removed

Limit now throws NotImplementedError for limits approaching a variable point
@0sidharth
flake8 changes
cbe6f66
@0sidharth
Removed factorial tests to a variable point
0db7073
@sympy-bot
Copy link

sympy-bot commented Jul 24, 2021 •
edited
Loading

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions

  • series

    • Limit now throws NotImplementedError if the point contains the variable wrt which limit is being found (#21775 by @0sidharth)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #9497
Fixes #18363
Fixes #21598

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
  * Added `polylog` nseries expansion
  * Fixes bug in `erf` nseries expansion leading to wrong number of terms
  * `log` leading term method handles `zoo` better, thus raises more often
  * `binomial` leading term method added
* series
  * `Limit` now throws `NotImplementedError` if the point contains the variable wrt which limit is being found
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

jksuom
jksuom reviewed Jul 24, 2021
View reviewed changes
jksuom
jksuom reviewed Jul 24, 2021
View reviewed changes
0sidharth
0sidharth commented Jul 25, 2021
View reviewed changes
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)



Significantly changed benchmark results (master vs previous release)


       before           after         ratio
     [ed9a550f]       [88d5736a]
     <sympy-1.8^0>                 
-      9.76±0.01s          4.95±0s     0.51  integrate.TimeIntegrationRisch02.time_doit(100)
-      9.65±0.03s       4.93±0.02s     0.51  integrate.TimeIntegrationRisch02.time_doit_risch(100)
+      82.0±0.7μs      3.02±0.02ms    36.80  matrices.TimeDiagonalEigenvals.time_eigenvals
-     5.82±0.07ms      3.21±0.04ms     0.55  solve.TimeRationalSystem.time_linsolve(10)
-     1.19±0.01ms          747±2μs     0.63  solve.TimeRationalSystem.time_linsolve(5)
-     1.40±0.03ms         909±20μs     0.65  solve.TimeSparseSystem.time_linsolve_eqs(10)
-     2.61±0.03ms      1.66±0.01ms     0.64  solve.TimeSparseSystem.time_linsolve_eqs(20)
-     3.73±0.05ms      2.47±0.01ms     0.66  solve.TimeSparseSystem.time_linsolve_eqs(30)



Full benchmark results can be found as artifacts in GitHub Actions

(click on checks at the top of the PR).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @jksuom





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            jksuom
  

      

      

      commented


        Jul 25, 2021


      
    


  





      


        



  
    

      
          
Looks good. Thanks!

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  



        @jksuom
  jksuom



        merged commit 6d63dcf
      into

      
  
    sympy:master
  


    Jul 25, 2021

  







  

  
  

  
      @0sidharth
  0sidharth


    
    deleted the
    
      
        limit_bug_fixes
    
    branch

    July 25, 2021 16:45    
    




  

  

    
  


  

      


    @0sidharth
0sidharth



    mentioned this pull request
    
      Jul 25, 2021
    





  


  

      

  
  Closed

  







  




  

  

    
  


  

      


    @0sidharth
0sidharth



    mentioned this pull request
    
      Sep 29, 2021
    





  


  

      

  
  Open

  







  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @jksuom
  
    jksuom



    
      
        
      
    
    jksuom left review comments

  



      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @0sidharth 
        
          @sympy-bot 
        
          @jksuom