Skip to content

[GSoC] Improvements to Limit.doit #21731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 15, 2021
Merged

[GSoC] Improvements to Limit.doit #21731

merged 12 commits into from
Jul 15, 2021

Conversation

0sidharth
Copy link
Member

@0sidharth 0sidharth commented Jul 11, 2021 •
edited
Loading

References to other Issues or PRs

Fixes #21530
Fixes #21701
#21721

Brief description of what is fixed or changed

Some heuristics present in the Limit.doit code are no longer needed after #21589, so they are removed.
A factor of 1/gamma(nu + 1) was missing from the besselj._eval_as_leading_term, which is now added.

Release Notes

  • functions
    • Fixed bugs related to direction in floor and ceiling leading terms
    • Fixed bugs in sinh and cosh leading terms
    • Added Ei, Ci, Shi, Chi leading term methods
    • sin and cos now return AccumBounds(-1, 1) as the leading term at real infinities

@sympy-bot
Copy link

sympy-bot commented Jul 11, 2021 •
edited
Loading

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions

    • Fixed bugs related to direction in floor and ceiling leading terms (#21731 by @0sidharth)

    • Fixed bugs in sinh and cosh leading terms (#21731 by @0sidharth)

    • Added Ei, Ci, Shi, Chi leading term methods (#21731 by @0sidharth)

    • sin and cos now return AccumBounds(-1, 1) as the leading term at real infinities (#21731 by @0sidharth)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #21530 
Fixes #21701 
#21721 

#### Brief description of what is fixed or changed
Some heuristics present in the `Limit.doit` code are no longer needed after #21589, so they are removed.
A factor of `1/gamma(nu + 1)` was missing from the `besselj._eval_as_leading_term`, which is now added.

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* functions
  * Fixed bugs related to direction in `floor` and `ceiling` leading terms
  * Fixed bugs in `sinh` and `cosh` leading terms
  * Added `Ei`, `Ci`, `Shi`, `Chi` leading term methods 
  * `sin` and `cos` now return `AccumBounds(-1, 1)` as the leading term at real infinities
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@0sidharth 0sidharth changed the title Improvements to Limit.doit [GSoC] Improvements to Limit.doit Jul 11, 2021
@0sidharth
Added Ei, Ci, Shi, Chi leading term methods
bd444d3 
Fixed internal NotImplementedErrors thrown on leadterm call in Limit.doit
Now only custom functions throw NotImplementedError (functions which won't
have an _eval_as_leading_term method defined)
jksuom
jksuom reviewed Jul 12, 2021
View reviewed changes
jksuom
jksuom reviewed Jul 12, 2021
View reviewed changes
jksuom
jksuom reviewed Jul 12, 2021
View reviewed changes
jksuom
jksuom reviewed Jul 13, 2021
View reviewed changes
@0sidharth 0sidharth force-pushed the limit_doit_improvements branch from b884fc2 to 5f7d3df Compare July 14, 2021 12:54
@jksuom
Copy link
Member

jksuom commented Jul 15, 2021

Looks good, thanks!

@jksuom jksuom merged commit 4f9e420 into sympy:master Jul 15, 2021
@0sidharth 0sidharth deleted the limit_doit_improvements branch July 15, 2021 08:40
This was referenced Jul 15, 2021
Closed
Closed
Closed
@0sidharth 0sidharth mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jksuom jksuom jksuom left review comments

Assignees
No one assigned
Labels
series
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect limit with bessel function besselj(m,z) Incorrect limit
4 participants
@0sidharth @sympy-bot @jksuom @oscarbenjamin