-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Use the proper theano printer-related function wrappers in test cases #20500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #20500 +/- ##
=============================================
- Coverage 75.781% 75.747% -0.035%
=============================================
Files 673 673
Lines 174510 174391 -119
Branches 41202 41198 -4
=============================================
- Hits 132247 132097 -150
- Misses 36546 36584 +38
+ Partials 5717 5710 -7 |
This looks good. I'm going to close and reopen to restart the tests. |
I just took care of the merge conflict. This should still be good to merge once the tests finish |
Sorry I forgot abut this. Are you aware that in the mean time sympy has now moved to supporting aesara? I'm not sure if that affects this patch or not. |
See here: |
No worries - and I have not, thanks for pointing that out. The move makes sense. I am not familiar with aesara beyond what Theano was, but the fixes in this PR simply ensure that the theano printer uses the correct wrappers in test functions (just making sure that the cache for |
Okay, thanks. I'm reassured to hear from someone who is (I assume) using sympy with theano. |
References to other Issues or PRs
Amends #15885
Brief description of what is fixed or changed
test_complexfunctions
usestheano_code
instead oftheano_code_
andtest_constantfunctions
usestheano_function
instead oftheano_function_
, which may yield unexpected results due to how the wrapper handles cache. This PR uses the correct definitions.Other comments
--
Release Notes
TheanoPrinter
constant and complex functions