Adding Min/Max support for decompogen.py #13623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now decompogen() function can support Min/Max functions
|
@smichr, please review |
|
ping @aktech , can you take a look at this? It seems too fragile to only be traversing certain args. Perhaps you could make a better suggestion. |
smichr
reviewed
Jan 23, 2018
| @@ -47,6 +50,14 @@ def decompogen(f, symbol): | |||
| result += [f.subs(f.args[0], symbol)] + decompogen(f.args[0], symbol) | |||
| return result | |||
|
|
|||
| # ===== Max/Min Functions ===== # | |||
| if isinstance(f, (Max, Min)): | |||
| result += [type(f)] | |||
There was a problem hiding this comment.
Adding what you are going to traverse in the for loop makes this fragile -- trust recursion here:
if symbol not in f.free_symbols or f == symbol:
return [f]
if isinstance(f, (Function, Pow)):
...
if isinstance(f, (Max, Min)):
rv = [type(f)]
for i in f.args:
rv.extend(decompogen(i, symbol))
return rv
But I don't know what is going to be done with the results and whether it is important to know that Min and Max were present...so maybe it should start out as rv = [].
|
@prajwalgatti Are you still interested to work on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13612
Now the code produces the following output:
>>>decompogen(Max(x, 3), x)[Max]>>>decompogen(Max(Min(sin(tan(x**4)), pi), sin(tan(x))), x)[Max, sin(x), tan(x), Min, sin(x), tan(x), x**4]