Skip to content

[Swup] Remove package #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

[Swup] Remove package #2985

merged 1 commit into from
Aug 12, 2025
+92 −1,436

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Aug 10, 2025 •
edited by Kocal
Loading

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #2733
License MIT

Follows #2814

This is mainly an attempt to discover what's required in term of changes.

@smnandre smnandre added this to the 3.x milestone Aug 10, 2025
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 10, 2025 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Swup
controller.d.ts 1.06 kB / 365 B Removed
controller.js 1.96 kB / 692 B Removed

@smnandre
Copy link
Member Author

fabbot find typo in pnpm.lock.yaml hashes 😅

image

@Kocal Kocal added the Swup label Aug 10, 2025
@carsonbot carsonbot changed the title [UX3] Remove Swup [Swup][UX3] Remove Swup Aug 10, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 10, 2025
@Kocal Kocal changed the title [Swup][UX3] Remove Swup [Swup] Remove package Aug 10, 2025
@Kocal
Copy link
Member

Kocal commented Aug 12, 2025

I did minor modifications on the /packages page to display deprecated packages in a second packages list:
image

@Kocal
Copy link
Member

Kocal commented Aug 12, 2025

Thank you @smnandre.

@Kocal Kocal merged commit 83f326d into symfony:3.x Aug 12, 2025
26 of 30 checks passed
@Kocal Kocal mentioned this pull request Aug 12, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer Swup
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smnandre @Kocal @carsonbot