-
Notifications
You must be signed in to change notification settings - Fork 300
Support all standard values of CMAKE_BUILD_TYPE #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! These four are indeed standard in cmake
so I think we should merge this.
Looks good. The failure seems unrelated:
But we should first send a separate PR to fix the failure, and then rebase this PR and merge, just in case. |
I fixed the failing tests on master. You could rebase on master and update the PR now. |
Add support for the two remaining standard values of `CMAKE_BUILD_TYPE`: `RelWithDebInfo` and `MinSizeRel`. This is particularly needed for Gentoo packaging that uses the most versatile `RelWithDebInfo` build variant for all packages. See: https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html
ab44e3a
to
d1cd04f
Compare
I tested the (new?) rebase functionality in the github GUI and some tests were directly cancelled for unknown reason. After I cancelled the full test run with the intention to restart it seems as if I cannot cancel the appveyor tests. Let us restart the tests when appveyor is done. |
I managed to cancel appveyor and restart. One test immediately fails and sets its status to cancelled with the following error:
Has anyone seen this before? |
Try to restart it again. |
I restarted the failed ones again. Now everything is running fine. Must have been some temporary glitch in github actions. |
Thanks |
Thank you! |
Add support for the two remaining standard values of
CMAKE_BUILD_TYPE
:RelWithDebInfo
andMinSizeRel
. This is particularly needed for Gentoo packaging that uses the most versatileRelWithDebInfo
build variant for all packages. See:https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html