Skip to content

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Dec 31, 2024

Add support for the two remaining standard values of CMAKE_BUILD_TYPE: RelWithDebInfo and MinSizeRel. This is particularly needed for Gentoo packaging that uses the most versatile RelWithDebInfo build variant for all packages. See:
https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html

Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! These four are indeed standard in cmake so I think we should merge this.

@certik
Copy link
Contributor

certik commented Jan 7, 2025

Looks good. The failure seems unrelated:

+++ retry_on_error conda create -q -p /home/runner/our_usr gmp=6.2.1 piranha=0.11 cmake=3.24.3 ''\''boost-cpp<1.79.0'\'''
+++ conda create -q -p /home/runner/our_usr gmp=6.2.1 piranha=0.11 cmake=3.24.3 ''\''boost-cpp<1.79.0'\'''

InvalidMatchSpec: Invalid spec ''boost-cpp<1.79.0'': Invalid version '1.79.0'': invalid character(s)

But we should first send a separate PR to fix the failure, and then rebase this PR and merge, just in case.

@rikardn
Copy link
Contributor

rikardn commented Jan 8, 2025

I fixed the failing tests on master. You could rebase on master and update the PR now.

Add support for the two remaining standard values of `CMAKE_BUILD_TYPE`:
`RelWithDebInfo` and `MinSizeRel`.  This is particularly needed
for Gentoo packaging that uses the most versatile `RelWithDebInfo`
build variant for all packages.  See:
https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html
@rikardn
Copy link
Contributor

rikardn commented Jan 9, 2025

I tested the (new?) rebase functionality in the github GUI and some tests were directly cancelled for unknown reason. After I cancelled the full test run with the intention to restart it seems as if I cannot cancel the appveyor tests. Let us restart the tests when appveyor is done.

@rikardn
Copy link
Contributor

rikardn commented Jan 9, 2025

I managed to cancel appveyor and restart. One test immediately fails and sets its status to cancelled with the following error:

Release-ubuntu-20.04-clang ({ "BUILD_TYPE": "Release", "OS": "ubuntu-20.04", "CC": "clang", "WITH_LLVM": 13, "EXTRA_APT_REPOSITORY": "deb http://apt.llvm.org/focal/ llvm-toolchain-focal-13 main", "EXTRA_APT_PACKAGES": "clang-13 llvm-13" })
The hosted runner encountered an error while running your job. (Error Type: Failure).

Has anyone seen this before?

@certik
Copy link
Contributor

certik commented Jan 9, 2025

Try to restart it again.

@rikardn
Copy link
Contributor

rikardn commented Jan 10, 2025

I restarted the failed ones again. Now everything is running fine. Must have been some temporary glitch in github actions.

@isuruf isuruf merged commit 34e7522 into symengine:master Jan 16, 2025
36 checks passed
@isuruf
Copy link
Member

isuruf commented Jan 16, 2025

Thanks

@mgorny mgorny deleted the cmake-build-type branch January 16, 2025 16:43
@mgorny
Copy link
Contributor Author

mgorny commented Jan 16, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants