Add Parser support for sign #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a test. |
added :) |
|
This looks good! Thank you. |
|
Hi @certik, Can you please have a look? |
|
It seems as if I cannot merge this since there is a test that fails. This failure is unrelated to this PR. Is this a new setting in github? Has anyone looked into the failing test? |
|
still failing on the same test.. |
|
The failing test uses the latest pre-release llvm, which seems to have some issue with the default llvm installation currently not including all required files, hopefully this is a fix for now: https://github.com/symengine/symengine/pull/2046/files |
|
Hi @isuruf , can you please have a look? |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.