Adding support for basic_as_two_terms #2024
Conversation
|
I think this might be ready to go now. |
There was a problem hiding this comment.
I think that this looks good now, this PR cleanly exposes the two methods for Add and Mul with minimal overhead. We leave the door open for any future improvement, such as making this work for "all classes". This minimal approach in this PR is enough to unblock us for Gruntz.
|
Thanks. Can LPython generate code for the C/C++ library so that we get a gruntz code for free? |
|
@isuruf that's what we are working on. LPython can generate LLVM, C and C++ code, in this order of maturity. The C++ code would still call SymEngine via the C API. We are still relatively at the beginning in the Gruntz implementation, you can follow our progress here: lcompilers/lpython#2688. Indeed, eventually it will be possible to just use the generated C code, possibly include it in SymEngine. The goal is that there is no runtime overhead of using SymPy in LPython compared to using C++/SymEngine directly. |
Fixes #2018