Skip to content

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Feb 16, 2024

  • added llvm 18 and latest llvm pre-release to CI so we get earlier info about any breaking changes to the llvm API
  • use a CMakeLists.txt instead of deprecated cmake --find-package to test installed symengine in CI
  • add missing find_dependency(Boost) to installed cmake config
  • resolves llvm_double.cpp not compatible with llvm-18 #2006

@lkeegan lkeegan requested review from bjodah and isuruf February 19, 2024 07:33
Copy link
Contributor

@bjodah bjodah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent!

@bjodah
Copy link
Contributor

bjodah commented Feb 20, 2024

I wonder what those "in progress" CI-checks are all about?

@bjodah bjodah enabled auto-merge (squash) February 20, 2024 07:26
@lkeegan
Copy link
Member Author

lkeegan commented Feb 20, 2024

I wonder what those "in progress" CI-checks are all about?

All the existing CI jobs were required - unfortunately it seems that this is done by github using a list of job names, so the two "in progress" checks are the two required CI jobs that have changed name.
I don't think I can modify the list of required jobs as I don't see a "settings" tab for this repo

@bjodah
Copy link
Contributor

bjodah commented Feb 20, 2024

Me neither. @certik would you mind giving Liam increased privileges for the symengine repo? (just a suggestion). Or edit the list manually?

@bjodah bjodah merged commit b3b9b43 into symengine:master Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm_double.cpp not compatible with llvm-18
2 participants