Minor fix for SBML printing of piecewise function #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the last piece condition is `true` then don't explicitly print this condition - This doesn't change symengine behaviour (other than sbml printing) - Both forms are equivalent for the symengine sbml parser - But it improves compatibility of the generated sbml string with the libSBML library - libSBML parser returns `NaN` if multiple explicit piece conditions evaluate to `true`
isuruf
approved these changes
Nov 20, 2023
|
@isuruf thanks for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truethen don't explicitly print this conditionNaNif multiple explicit piece conditions evaluate totrue