Skip to content

Fix (negative_integer)**rational #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fix (negative_integer)**rational #1998

merged 1 commit into from
Dec 24, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Dec 8, 2023

@isuruf isuruf requested a review from a team December 8, 2023 15:12
bjodah
bjodah approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bjodah bjodah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good (although I have to admint that I have little experience working with these parts). Should we drop the commented lines (211-212), or add/rewrite as text giving a bit more context?

@bjodah
Copy link
Contributor

bjodah commented Dec 24, 2023

Let's get this in. Merry Christmas.

@bjodah bjodah merged commit 6cfa48b into symengine:master Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjodah bjodah bjodah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong result when simplifying complex expression
2 participants
@isuruf @bjodah